LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Daniel Barkalow <barkalow@iabervon.org>
To: Roland Dreier <rdreier@cisco.com>
Cc: Petr Vandrovec <petr@vandrovec.name>,
	jeff@garzik.org, linux-kernel@vger.kernel.org, akpm@osdl.org
Subject: Re: [PATCH] Unbreak MSI on ATI devices
Date: Fri, 5 Jan 2007 18:57:24 -0500 (EST)	[thread overview]
Message-ID: <Pine.LNX.4.64.0701051847310.20138@iabervon.org> (raw)
In-Reply-To: <ada4pr61mie.fsf@cisco.com>

On Thu, 4 Jan 2007, Roland Dreier wrote:

>  > So my question is - what is real reason for disabling INTX when in MSI mode?
>  > According to PCI spec it should not be needed, and it hurts at least chips
>  > listed below:
>  > 
>  > 00:13.0 0c03: 1002:4374 USB Controller: ATI Technologies Inc IXP SB400 USB Host Controller
>  > 00:13.1 0c03: 1002:4375 USB Controller: ATI Technologies Inc IXP SB400 USB Host Controller
>  > 00:13.2 0c03: 1002:4373 USB Controller: ATI Technologies Inc IXP SB400 USB2 Host Controller 
> 
> heh... I'm not gloating or anything... but I am glad that some ASIC
> designer was careless enough to prove me right when I said going
> beyond what the PCI spec requires is dangerous.

No more dangerous than expecting exactly following the PCI spec to be 
sufficient; at least some nVidia devices misbehave if you don't disable 
INTx when using MSI, while at least some ATI devices misehave if you do 
disable INTx. The only *safe* thing is to ignore the PCI spec and match 
the behavior of Windows. In this case, that's just don't use MSI yet.

Of course, this should be relatively easy to handle with quirks, 
especially if it's predictable which hardware bug you get from the vendor 
id.

	-Daniel
*This .sig left intentionally blank*

  parent reply	other threads:[~2007-01-05 23:57 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-12-21  7:55 Petr Vandrovec
2006-12-21  8:21 ` Jeff Garzik
2006-12-25  4:01 ` Daniel Barkalow
2007-01-04 21:59 ` Roland Dreier
2007-01-05  9:07   ` Petr Vandrovec
2007-01-06  0:54     ` Daniel Barkalow
2007-01-05 23:57   ` Daniel Barkalow [this message]
     [not found] <fa.yZrxrHh1AWLcv/+D2xYZ1VhVYb8@ifi.uio.no>
2006-12-21 14:36 ` Robert Hancock

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Pine.LNX.4.64.0701051847310.20138@iabervon.org \
    --to=barkalow@iabervon.org \
    --cc=akpm@osdl.org \
    --cc=jeff@garzik.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=petr@vandrovec.name \
    --cc=rdreier@cisco.com \
    --subject='Re: [PATCH] Unbreak MSI on ATI devices' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).