LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Jiri Kosina <jikos@jikos.cz>
To: Simon Budig <simon@budig.de>
Cc: Vojtech Pavlik <vojtech@suse.cz>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2.6.19] USB HID: proper LED-mapping (support for SpaceNavigator)
Date: Mon, 15 Jan 2007 09:42:42 +0100 (CET)	[thread overview]
Message-ID: <Pine.LNX.4.64.0701150938180.16747@twin.jikos.cz> (raw)
In-Reply-To: <20070114231135.GA29966@budig.de>

On Mon, 15 Jan 2007, Simon Budig wrote:

> This change introduces a mapping for LED indicators between the USB HID 
> specification and the Linux input subsystem. The previous code properly 
> mapped the LEDs relevant for Keyboards, but garbeled the remaining ones. 
> With this change all LED enums from the input system get mapped to more 
> or less equivalent LED numbers from the HID specification. This patch 
> also extends the debug output and ensures that the unused bits in a HID 
> report to the device are zeroed out. This makes the 3Dconnexion 
> SpaceNavigator fully usable with the linux input system.

Hi Simon,

thanks for the patch. It seems that it is based on pre-2.6.20-rc1 kernel 
(this is where the USBHID split happened and generic HID layer was 
introduced). Could you please rebase it against newer version of kernel 
and resend it?

All your changes happen to be in the transport-independent code, so it 
seems that this would be rather trivial task - probably only pathnames 
(and diff offsets) will change - your changes should now go to 
drivers/hid/hid-*, not drivers/usb/input/hid-*.

Thanks,

-- 
Jiri Kosina

  reply	other threads:[~2007-01-15  8:42 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-01-14 23:11 Simon Budig
2007-01-15  8:42 ` Jiri Kosina [this message]
2007-01-15 16:25   ` Simon Budig
2007-01-15 16:44     ` Jiri Kosina
2007-01-15 17:32       ` Simon Budig
2007-01-15 21:14         ` Jiri Kosina
2007-01-15 22:55           ` Simon Budig
2007-01-15 18:32       ` Vojtech Pavlik
2007-01-15 18:38         ` Marcel Holtmann
2007-01-15 18:56           ` Vojtech Pavlik
2007-01-15 16:28 ` [PATCH 2.6.20-rc5] " Simon Budig
2007-01-15 17:34   ` Simon Budig

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Pine.LNX.4.64.0701150938180.16747@twin.jikos.cz \
    --to=jikos@jikos.cz \
    --cc=linux-kernel@vger.kernel.org \
    --cc=simon@budig.de \
    --cc=vojtech@suse.cz \
    --subject='Re: [PATCH 2.6.19] USB HID: proper LED-mapping (support for SpaceNavigator)' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).