LKML Archive on lore.kernel.org
 help / color / Atom feed
From: "Robert P. J. Day" <rpjday@mindspring.com>
To: Randy Dunlap <randy.dunlap@oracle.com>
Cc: "Ahmed S. Darwish" <darwish.07@gmail.com>,
	isely@pobox.com, video4linux-list@redhat.com,
	linux-kernel@vger.kernel.org, trivial@kernel.org
Subject: Re: [PATCH 2.6.20-rc5 2/4] pvrusb2: Use ARRAY_SIZE macro
Date: Tue, 16 Jan 2007 13:23:32 -0500 (EST)
Message-ID: <Pine.LNX.4.64.0701161317530.21544@CPE00045a9c397f-CM001225dbafb6> (raw)
In-Reply-To: <20070116101633.39e57884.randy.dunlap@oracle.com>

On Tue, 16 Jan 2007, Randy Dunlap wrote:

> On Tue, 16 Jan 2007 03:36:16 -0500 (EST) Robert P. J. Day wrote:
>
> > On Tue, 16 Jan 2007, Ahmed S. Darwish wrote:
> >
> > > Use ARRAY_SIZE macro in pvrusb2-hdw.c file
> > >
> > > Signed-off-by: Ahmed S. Darwish <darwish.07@gmail.com>
> >
> > ... snip ...
> >
> > i'm not sure it's worth submitting multiple patches to convert
> > code expressions to the ARRAY_SIZE() macro since i was going to
> > wait for the next kernel release, and do that in one fell swoop
> > with a single patch.
> >
> > but if people higher up the food chain think it's a better idea to
> > do it a little at a time, that's fine.
>
> I'm not strictly on the food chain, but these 4 patches to pvrusb2
> should have been sent as one patch IMO.

  it's not like i'm trying to be territorial or anything.  if someone
wants to handle all these changes, go wild.  it's just that this
discussion of ARRAY_SIZE started back in december:

  http://lkml.org/lkml/2006/12/17/85

  i have a check for possibilities where this change can be done in my
"style" script:

  $ grep -Er "sizeof ?\(?([^\)]+)\)? ?/ ?sizeof ?\(?.*\1.*" .

  and i also have a script that crawls the tree, making the more
obvious changes.  (it will miss spots where the expression is broken
over two lines, stuff like that, so there will probably be a few
stragglers that will have to be done manually.)

  i haven't done anything with this lately as i was waiting for the
new release, whereupon i'm assuming the floodgates will be opened
and all the pending changes will finally start to wander upstream.
then all these changes might make sense as a multi-part patch.

  but, as i said, i'll leave this to people much smarter than me.

rday


  reply index

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-01-16  8:01 Ahmed S. Darwish
2007-01-16  8:36 ` Robert P. J. Day
2007-01-16 18:16   ` Randy Dunlap
2007-01-16 18:23     ` Robert P. J. Day [this message]
2007-01-16 19:07     ` Ahmed S. Darwish
2007-01-19  6:05       ` Mike Isely
2007-01-16 18:54   ` Ahmed S. Darwish
2007-01-16 20:54     ` Mauro Carvalho Chehab

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Pine.LNX.4.64.0701161317530.21544@CPE00045a9c397f-CM001225dbafb6 \
    --to=rpjday@mindspring.com \
    --cc=darwish.07@gmail.com \
    --cc=isely@pobox.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=randy.dunlap@oracle.com \
    --cc=trivial@kernel.org \
    --cc=video4linux-list@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

LKML Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lkml.kernel.org/lkml/0 lkml/git/0.git
	git clone --mirror https://lkml.kernel.org/lkml/1 lkml/git/1.git
	git clone --mirror https://lkml.kernel.org/lkml/2 lkml/git/2.git
	git clone --mirror https://lkml.kernel.org/lkml/3 lkml/git/3.git
	git clone --mirror https://lkml.kernel.org/lkml/4 lkml/git/4.git
	git clone --mirror https://lkml.kernel.org/lkml/5 lkml/git/5.git
	git clone --mirror https://lkml.kernel.org/lkml/6 lkml/git/6.git
	git clone --mirror https://lkml.kernel.org/lkml/7 lkml/git/7.git
	git clone --mirror https://lkml.kernel.org/lkml/8 lkml/git/8.git
	git clone --mirror https://lkml.kernel.org/lkml/9 lkml/git/9.git
	git clone --mirror https://lkml.kernel.org/lkml/10 lkml/git/10.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 lkml lkml/ https://lkml.kernel.org/lkml \
		linux-kernel@vger.kernel.org
	public-inbox-index lkml

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.linux-kernel


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git