LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Mike Isely <isely@isely.net>
To: "Ahmed S. Darwish" <darwish.07@gmail.com>
Cc: Randy Dunlap <randy.dunlap@oracle.com>,
"Robert P. J. Day" <rpjday@mindspring.com>,
video4linux-list@redhat.com,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
trivial@kernel.org, Mike Isely at pobox <isely@pobox.com>
Subject: Re: [PATCH 2.6.20-rc5 2/4] pvrusb2: Use ARRAY_SIZE macro
Date: Fri, 19 Jan 2007 00:05:58 -0600 (CST) [thread overview]
Message-ID: <Pine.LNX.4.64.0701190003020.26643@cnc.isely.net> (raw)
In-Reply-To: <20070116190738.GD718@Ahmed>
On Tue, 16 Jan 2007, Ahmed S. Darwish wrote:
> On Tue, Jan 16, 2007 at 10:16:33AM -0800, Randy Dunlap wrote:
> > On Tue, 16 Jan 2007 03:36:16 -0500 (EST) Robert P. J. Day wrote:
> >
> > > On Tue, 16 Jan 2007, Ahmed S. Darwish wrote:
> > >
> > > > Use ARRAY_SIZE macro in pvrusb2-hdw.c file
> > > >
> > > > Signed-off-by: Ahmed S. Darwish <darwish.07@gmail.com>
> > >
> > > ... snip ...
> > >
> > > i'm not sure it's worth submitting multiple patches to convert code
> > > expressions to the ARRAY_SIZE() macro since i was going to wait for
> > > the next kernel release, and do that in one fell swoop with a single
> > > patch.
> > >
> > > but if people higher up the food chain think it's a better idea to do
> > > it a little at a time, that's fine.
> >
> > I'm not strictly on the food chain, but these 4 patches to
> > pvrusb2 should have been sent as one patch IMO.
>
> Here's the same patch in one file as suggested.
>
> A patch to use ARRAY_SIZE macro when appropriate.
>
> Signed-off-by: Ahmed S. Darwish <darwish.07@gmail.com>
> ---
Ahmed:
I've pulled your patch into my driver source and will propagate it up
appropriately as part of the next batch of pvrusb2 changes to come out
of the v4l-dvb repository.
-Mike
--
| Mike Isely | PGP fingerprint
Spammers Die!! | | 03 54 43 4D 75 E5 CC 92
| isely @ pobox (dot) com | 71 16 01 E2 B5 F5 C1 E8
| |
next prev parent reply other threads:[~2007-01-19 6:06 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-01-16 8:01 Ahmed S. Darwish
2007-01-16 8:36 ` Robert P. J. Day
2007-01-16 18:16 ` Randy Dunlap
2007-01-16 18:23 ` Robert P. J. Day
2007-01-16 19:07 ` Ahmed S. Darwish
2007-01-19 6:05 ` Mike Isely [this message]
2007-01-16 18:54 ` Ahmed S. Darwish
2007-01-16 20:54 ` Mauro Carvalho Chehab
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Pine.LNX.4.64.0701190003020.26643@cnc.isely.net \
--to=isely@isely.net \
--cc=darwish.07@gmail.com \
--cc=isely@pobox.com \
--cc=linux-kernel@vger.kernel.org \
--cc=randy.dunlap@oracle.com \
--cc=rpjday@mindspring.com \
--cc=trivial@kernel.org \
--cc=video4linux-list@redhat.com \
--subject='Re: [PATCH 2.6.20-rc5 2/4] pvrusb2: Use ARRAY_SIZE macro' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).