LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Jiri Kosina <jkosina@suse.cz>
To: Anssi Hannula <anssi.hannula@gmail.com>
Cc: linux-usb-devel <linux-usb-devel@lists.sourceforge.net>,
	linux-input@atrey.karlin.mff.cuni.cz,
	LKML <linux-kernel@vger.kernel.org>,
	Dmitry Torokhov <dmitry.torokhov@gmail.com>
Subject: Re: [patch] hid: put usb_interface instead of usb_device into hid->dev
Date: Fri, 19 Jan 2007 19:14:16 +0100 (CET)	[thread overview]
Message-ID: <Pine.LNX.4.64.0701191907580.31347@jikos.suse.cz> (raw)
In-Reply-To: <45B0FFB1.3000900@gmail.com>

On Fri, 19 Jan 2007, Anssi Hannula wrote:

> The commit 4916b3a57fc94664677d439b911b8aaf86c7ec23 introduced a
> hid regression between 2.6.19 and 2.6.20-rc1. The device put in
> input_dev->cdev is now of type usb_device instead of usb_interface.

Yes, this is apparently a bug. Thanks a lot for the patch.

> Fix this by assigning the intf->dev into hid->dev, and fixing all the 
> users.
> 
> Signed-off-by: Anssi Hannula <anssi.hannula@gmail.com>
> 
> ---
> 
> I recommend this fix to go to the stable tree before 2.6.20 is released.

Looks OK to me. I have queued it in HID tree - I am going to push this 
upstream in a few days.

-- 
Jiri Kosina


      reply	other threads:[~2007-01-19 18:14 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-01-19 17:28 Anssi Hannula
2007-01-19 18:14 ` Jiri Kosina [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Pine.LNX.4.64.0701191907580.31347@jikos.suse.cz \
    --to=jkosina@suse.cz \
    --cc=anssi.hannula@gmail.com \
    --cc=dmitry.torokhov@gmail.com \
    --cc=linux-input@atrey.karlin.mff.cuni.cz \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb-devel@lists.sourceforge.net \
    --subject='Re: [patch] hid: put usb_interface instead of usb_device into hid->dev' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).