LKML Archive on
help / color / mirror / Atom feed
From: Hugh Dickins <>
To: Ken Chen <>
Cc: Adam Litke <>, Andrew Morton <>,
	William Irwin <>,
	David Gibson <>,,
Subject: Re: [PATCH] Don't allow the stack to grow into hugetlb reserved regions
Date: Sat, 27 Jan 2007 09:08:58 +0000 (GMT)	[thread overview]
Message-ID: <> (raw)
In-Reply-To: <>

On Fri, 26 Jan 2007, Ken Chen wrote:
> On 1/26/07, Hugh Dickins <> wrote:
> > Less trivial (and I wonder whether you've come to this from an ia64
> > or a powerpc direction): I notice that ia64 has more stringent REGION
> > checks in its ia64_do_page_fault, before calling expand_stack or
> > expand_upwards.  So on that path, the usual path, I think your
> > new check in acct_stack_growth is unnecessary on ia64;
> I think you are correct. This appears to affect powerpc only. On ia64,
> hugetlb lives in a completely different region and they can never step
> into normal stack address space. And for x86, there isn't a thing called
> "reserved address space" for hugetlb mapping.

Thanks, that's reassuring for the hugetlb case, and therefore Adam's
patch should not be delayed.  But it does leave open the question I
was raising in the text you've snipped: if ia64 needs those stringent
REGION checks in its ia64_do_page_fault path, don't we need to add
them some(messy)how in the get_user_pages find_extend_vma path?


  reply	other threads:[~2007-01-27  9:08 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-01-25 21:40 Adam Litke
2007-01-26 20:05 ` Andrew Morton
2007-01-26 21:02 ` Hugh Dickins
2007-01-26 22:48   ` Ken Chen
2007-01-27  9:08     ` Hugh Dickins [this message]
2007-01-28 20:27       ` Ken Chen
2007-01-29 17:26         ` Hugh Dickins
2007-01-29 18:32           ` Ken Chen
2007-01-29 18:34 Adam Litke

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \ \ \ \ \ \ \
    --subject='Re: [PATCH] Don'\''t allow the stack to grow into hugetlb reserved regions' \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).