LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: "Robert P. J. Day" <rpjday@mindspring.com>
To: Eric Sandeen <sandeen@sandeen.net>
Cc: xfs-masters@oss.sgi.com,
	Linux kernel mailing list <linux-kernel@vger.kernel.org>,
	Andrew Morton <akpm@osdl.org>,
	dgc@sgi.com
Subject: Re: [xfs-masters] [PATCH} XFS: Remove placeholders for unimplemented functionality.
Date: Mon, 29 Jan 2007 03:06:51 -0500 (EST)	[thread overview]
Message-ID: <Pine.LNX.4.64.0701290305240.12287@CPE00045a9c397f-CM001225dbafb6> (raw)
In-Reply-To: <45BD7F0A.1000004@sandeen.net>

On Sun, 28 Jan 2007, Eric Sandeen wrote:

> Robert P. J. Day wrote:
> >   Remove a couple kernel config variables (FS_POSIX_CAP and
> > FS_POSIX_MAC) that represent placeholders for unimplemented
> > functionality.
> >
> > Signed-off-by: Robert P. J. Day <rpjday@mindspring.com>
> >
> > ---
>
> ...
>
> > diff --git a/fs/xfs/xfs_cap.h b/fs/xfs/xfs_cap.h
> > index 7a0e482..cfedfd1 100644
> > --- a/fs/xfs/xfs_cap.h
> > +++ b/fs/xfs/xfs_cap.h
>
> ...
>
> > -#else
> >  #define xfs_cap_vset(v,p,sz)	(-EOPNOTSUPP)
> >  #define xfs_cap_vget(v,p,sz)	(-EOPNOTSUPP)
> >  #define xfs_cap_vremove(v)	(-EOPNOTSUPP)
> >  #define _CAP_EXISTS		(NULL)
> > -#endif
> >
> >  #endif	/* __KERNEL__ */
>
> By the time you do this, probably may as well remove the whole file;
> the leftover 4 definitions never seem to be used.
>
> The same may go for xfs_mac.h.
>
> -Eric

good point.  david chinner (dgc) already mentioned that he'd prefer to
run this through the XFS tree so i'll leave this in his capable hands.

rday

-- 
========================================================================
Robert P. J. Day
Linux Consulting, Training and Annoying Kernel Pedantry
Waterloo, Ontario, CANADA

http://www.fsdev.dreamhosters.com/wiki/index.php?title=Main_Page
========================================================================

      parent reply	other threads:[~2007-01-29  8:07 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-01-28 21:00 Robert P. J. Day
2007-01-29  4:58 ` [xfs-masters] " Eric Sandeen
2007-01-29  7:01   ` Christoph Hellwig
2007-01-29  8:06   ` Robert P. J. Day [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Pine.LNX.4.64.0701290305240.12287@CPE00045a9c397f-CM001225dbafb6 \
    --to=rpjday@mindspring.com \
    --cc=akpm@osdl.org \
    --cc=dgc@sgi.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=sandeen@sandeen.net \
    --cc=xfs-masters@oss.sgi.com \
    --subject='Re: [xfs-masters] [PATCH} XFS: Remove placeholders for unimplemented functionality.' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).