LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Christoph Lameter <clameter@sgi.com>
To: Andrew Morton <akpm@osdl.org>
Cc: Frederik Deweerdt <deweerdt@free.fr>,
	linux-kernel@vger.kernel.org, trond.myklebust@fys.uio.no,
	Christoph Lameter <clameter@engr.sgi.com>
Subject: Re: [-mm patch] BUG at net/sunrpc/svc.c:128 (was Re: 2.6.20-rc6-mm2)
Date: Mon, 29 Jan 2007 09:49:50 -0800 (PST)	[thread overview]
Message-ID: <Pine.LNX.4.64.0701290948090.28644@schroedinger.engr.sgi.com> (raw)
In-Reply-To: <20070129093247.54ba43c9.akpm@osdl.org>

On Mon, 29 Jan 2007, Andrew Morton wrote:

> >  static int
> >  svc_pool_map_init_percpu(struct svc_pool_map *m)
> >  {
> > -	unsigned int maxpools = nr_node_ids;
> > +	unsigned int maxpools = num_online_cpus();
> >  	unsigned int pidx = 0;
> >  	unsigned int cpu;
> >  	int err;
> 
> Thanks.

Patch has the wrong solution as detailed in another message.

The line should be reverted to what it was before:

  unsigned int maxpools = highest_possible_processor_id()+1;


 
> Christoph, can you pleeeeeze be more careful?  A few seconds inattention
> and a dopey copy-n-paste bug leads to large amounts of wasted time for
> other people.

Looks like I need to add another nr_cpu_ids? I did not realize that the 
same weird thing was done for cpus, sigh.

  reply	other threads:[~2007-01-29 17:50 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-01-29  8:12 2.6.20-rc6-mm2 Andrew Morton
2007-01-29 11:02 ` 2.6.20-rc6-mm2 Jiri Kosina
2007-01-29 15:40   ` 2.6.20-rc6-mm2 Thomas Gleixner
2007-01-29 16:28     ` 2.6.20-rc6-mm2 Jiri Kosina
2007-01-30 10:27     ` 2.6.20-rc6-mm2 Maciej Rutecki
2007-01-29 11:21 ` [-mm patch] BUG at net/sunrpc/svc.c:128 (was Re: 2.6.20-rc6-mm2) Frederik Deweerdt
2007-01-29 17:32   ` Andrew Morton
2007-01-29 17:49     ` Christoph Lameter [this message]
2007-01-30 14:17       ` Frederik Deweerdt
2007-01-29 16:22 ` 2.6.20-rc6-mm2 Karsten Wiese
2007-01-29 16:38   ` 2.6.20-rc6-mm2 Thomas Gleixner
2007-01-29 17:28 ` 2.6.20-rc6-mm2 - modules_install error Matthew Frost
2007-01-29 21:37 ` 2.6.20-rc6-mm2 Laurent Riffard
2007-01-29 21:59 ` [PATCH] compile and link utsname_sysctl.o Laurent Riffard
2007-01-30 15:11   ` Eric W. Biederman
2007-01-30 16:26     ` Laurent Riffard
2007-02-06 22:13 ` [-mm patch] make kernel/time/timer_stats.c:nr_entries static Adrian Bunk
2007-02-06 22:15   ` Ingo Molnar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Pine.LNX.4.64.0701290948090.28644@schroedinger.engr.sgi.com \
    --to=clameter@sgi.com \
    --cc=akpm@osdl.org \
    --cc=clameter@engr.sgi.com \
    --cc=deweerdt@free.fr \
    --cc=linux-kernel@vger.kernel.org \
    --cc=trond.myklebust@fys.uio.no \
    --subject='Re: [-mm patch] BUG at net/sunrpc/svc.c:128 (was Re: 2.6.20-rc6-mm2)' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).