LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
* [SLAB] Shutdown cache_reaper when cpu goes down
@ 2007-02-01 19:13 Christoph Lameter
  2007-02-01 23:19 ` Christoph Lameter
  2007-02-02  0:55 ` Andrew Morton
  0 siblings, 2 replies; 4+ messages in thread
From: Christoph Lameter @ 2007-02-01 19:13 UTC (permalink / raw)
  To: akpm; +Cc: Oleg Nesterov, linux-kernel

Shutdown the cache_reaper if the cpu is brought down and set the 
cache_reap.func to NULL. Otherwise hotplug shuts down the reaper for good.

Signed-off-by: Christoph Lameter <clameter@sgi.com>

Index: linux-2.6.20-rc6-mm2/mm/slab.c
===================================================================
--- linux-2.6.20-rc6-mm2.orig/mm/slab.c	2007-01-29 14:27:34.199229828 -0600
+++ linux-2.6.20-rc6-mm2/mm/slab.c	2007-01-30 13:55:57.936838878 -0600
@@ -1271,6 +1271,18 @@ static int __cpuinit cpuup_callback(stru
 		start_cpu_timer(cpu);
 		break;
 #ifdef CONFIG_HOTPLUG_CPU
+  	case CPU_DOWN_PREPARE:
+		/*
+		 * Shutdown cache reaper. Note that the cache_chain_mutex is
+		 * held so that cache_reap() cannot modify reap_work
+		 * concurrently.
+		*/
+		cancel_rearming_delayed_work(&per_cpu(reap_work, cpu));
+		per_cpu(reap_work, cpu).work.func = NULL;
+  		break;
+  	case CPU_DOWN_FAILED:
+		start_cpu_timer(cpu);
+  		break;
 	case CPU_DEAD:
 		/*
 		 * Even if all the cpus of a node are down, we don't free the

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [SLAB] Shutdown cache_reaper when cpu goes down
  2007-02-01 19:13 [SLAB] Shutdown cache_reaper when cpu goes down Christoph Lameter
@ 2007-02-01 23:19 ` Christoph Lameter
  2007-02-02  0:55 ` Andrew Morton
  1 sibling, 0 replies; 4+ messages in thread
From: Christoph Lameter @ 2007-02-01 23:19 UTC (permalink / raw)
  To: akpm; +Cc: Oleg Nesterov, linux-kernel

The comments do not explain correctly what is going on. Sorry Oleg but it 
seems that the protection of the assignment to reap_work is different that 
what we initially thought.

Signed-off-by: Christoph Lameter <clameter@sgi.com>

Index: current/mm/slab.c
===================================================================
--- current.orig/mm/slab.c	2007-02-01 15:07:09.000000000 -0800
+++ current/mm/slab.c	2007-02-01 15:09:21.000000000 -0800
@@ -1274,10 +1274,12 @@ static int __cpuinit cpuup_callback(stru
   	case CPU_DOWN_PREPARE:
 		/*
 		 * Shutdown cache reaper. Note that the cache_chain_mutex is
-		 * held so that cache_reap() cannot modify reap_work
-		 * concurrently.
+		 * held so that if cache_reap() is invoked it cannot do
+		 * anything expensive but will only modify reap_work
+		 * and reschedule the timer.
 		*/
 		cancel_rearming_delayed_work(&per_cpu(reap_work, cpu));
+		/* Now the cache_reaper is guaranteed to be not running. */
 		per_cpu(reap_work, cpu).work.func = NULL;
   		break;
   	case CPU_DOWN_FAILED:

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [SLAB] Shutdown cache_reaper when cpu goes down
  2007-02-01 19:13 [SLAB] Shutdown cache_reaper when cpu goes down Christoph Lameter
  2007-02-01 23:19 ` Christoph Lameter
@ 2007-02-02  0:55 ` Andrew Morton
  2007-02-02  2:14   ` Christoph Lameter
  1 sibling, 1 reply; 4+ messages in thread
From: Andrew Morton @ 2007-02-02  0:55 UTC (permalink / raw)
  To: Christoph Lameter; +Cc: Oleg Nesterov, linux-kernel

On Thu, 1 Feb 2007 11:13:29 -0800 (PST)
Christoph Lameter <clameter@sgi.com> wrote:

> Shutdown the cache_reaper if the cpu is brought down and set the 
> cache_reap.func to NULL. Otherwise hotplug shuts down the reaper for good.
> 
> Signed-off-by: Christoph Lameter <clameter@sgi.com>
> 
> Index: linux-2.6.20-rc6-mm2/mm/slab.c
> ===================================================================
> --- linux-2.6.20-rc6-mm2.orig/mm/slab.c	2007-01-29 14:27:34.199229828 -0600
> +++ linux-2.6.20-rc6-mm2/mm/slab.c	2007-01-30 13:55:57.936838878 -0600
> @@ -1271,6 +1271,18 @@ static int __cpuinit cpuup_callback(stru
>  		start_cpu_timer(cpu);
>  		break;
>  #ifdef CONFIG_HOTPLUG_CPU
> +  	case CPU_DOWN_PREPARE:
> +		/*
> +		 * Shutdown cache reaper. Note that the cache_chain_mutex is
> +		 * held so that cache_reap() cannot modify reap_work
> +		 * concurrently.
> +		*/
> +		cancel_rearming_delayed_work(&per_cpu(reap_work, cpu));
> +		per_cpu(reap_work, cpu).work.func = NULL;
> +  		break;
> +  	case CPU_DOWN_FAILED:
> +		start_cpu_timer(cpu);
> +  		break;
>  	case CPU_DEAD:
>  		/*
>  		 * Even if all the cpus of a node are down, we don't free the

Is this bug unique to the changes in -mm, or is it in mainline?

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [SLAB] Shutdown cache_reaper when cpu goes down
  2007-02-02  0:55 ` Andrew Morton
@ 2007-02-02  2:14   ` Christoph Lameter
  0 siblings, 0 replies; 4+ messages in thread
From: Christoph Lameter @ 2007-02-02  2:14 UTC (permalink / raw)
  To: Andrew Morton; +Cc: Oleg Nesterov, linux-kernel

On Thu, 1 Feb 2007, Andrew Morton wrote:

> Is this bug unique to the changes in -mm, or is it in mainline?

Mainline is also affected. However, mainline may need a different fix 
since the hotplug notifier scheme was changed.


^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2007-02-02  2:14 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2007-02-01 19:13 [SLAB] Shutdown cache_reaper when cpu goes down Christoph Lameter
2007-02-01 23:19 ` Christoph Lameter
2007-02-02  0:55 ` Andrew Morton
2007-02-02  2:14   ` Christoph Lameter

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).