LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Linus Torvalds <torvalds@linux-foundation.org>
To: David Woodhouse <dwmw2@infradead.org>
Cc: Ingo Molnar <mingo@elte.hu>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [patch] MTD: fix DOC2000/2001/2001PLUS build error
Date: Mon, 5 Feb 2007 14:21:41 -0800 (PST)	[thread overview]
Message-ID: <Pine.LNX.4.64.0702051409110.8424@woody.linux-foundation.org> (raw)
In-Reply-To: <1170712393.29759.925.camel@pmac.infradead.org>



On Mon, 5 Feb 2007, David Woodhouse wrote:
>
> Ten years ago, people used 'depends on' to fix the tools, so that then
> you want to enable something like USB_STORAGE, it can automatically turn
> SCSI on for you.
> 
> Isn't that what you wanted?

Try it. It's not what it does. 

If you have a 

	depends on SCSI

and you did not say you wanted SCSI, you'll never even *see* the question.

It will *not* turn on SCSI automatically for you. Quite the reverse. It 
will not even show you the option.

In contrast, it you do a

	select SCSI

you'll see the question, and it will do exactly what you claim "depends 
on" does. Which yes, is what we want.

So what's your problem? You argue as if you didn't understand the 
difference between "depends on" and "select".

As an example of this, look at SATA. It does "select SCSI" if you select 
CONFIG_ATA, _exactly_ because it actually wants to turn on the SCSI layer 
*regardless* of what the user said. Because if the user said "n" to SCSI, 
the user simply didn't know that the SATA code uses the SCSI code.

Which is an example of what I've been saying all along: "select" makes 
sense. USB_STORAGE should have done the same.

Claiming that "select" is evil is just totally strange.

		Linus

  reply	other threads:[~2007-02-05 22:22 UTC|newest]

Thread overview: 95+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-02-04 19:10 Super Kernel Sunday! Linus Torvalds
2007-02-04 19:40 ` Bauke Jan Douma
2007-02-04 21:00   ` Gene Heskett
2007-02-04 21:11   ` Kevin K
2007-02-04 19:56 ` Alessandro Suardi
2007-02-05  8:39 ` Jonathan Sambrook
2007-02-05  8:45 ` [patch] MTD: fix DOC2000/2001/2001PLUS build error Ingo Molnar
2007-02-05 13:06   ` Josh Boyer
2007-02-05 13:34   ` David Woodhouse
2007-02-05 15:56     ` Ingo Molnar
2007-02-05 16:08       ` Arjan van de Ven
2007-02-05 16:12       ` Russell King
2007-02-05 16:17         ` Ingo Molnar
2007-02-05 16:22       ` David Woodhouse
2007-02-05 16:26         ` Ingo Molnar
2007-02-05 16:31           ` Ingo Molnar
2007-02-05 16:58             ` Linus Torvalds
2007-02-05 17:05               ` Ingo Molnar
2007-02-05 17:08               ` Russell King
2007-02-05 21:15               ` Ingo Oeser
2007-02-06 13:32                 ` Gerhard Mack
2007-02-05 21:17               ` David Woodhouse
2007-02-05 21:28                 ` Linus Torvalds
2007-02-05 21:39                   ` David Woodhouse
2007-02-05 21:49                     ` Linus Torvalds
2007-02-05 21:53                       ` David Woodhouse
2007-02-05 22:21                         ` Linus Torvalds [this message]
2007-02-05 22:31                           ` Randy Dunlap
2007-02-05 23:09                             ` Linus Torvalds
2007-02-05 23:21                               ` David Woodhouse
2007-02-05 23:32                                 ` Linus Torvalds
2007-02-06  0:04                                   ` Mark Rustad
2007-02-06 15:55                                     ` Bill Davidsen
2007-02-06 16:20                                       ` Mark Rustad
2007-02-06  9:45                                   ` David Woodhouse
2007-02-06 15:51                                     ` Bill Davidsen
2007-02-06 16:53                                     ` Linus Torvalds
2007-02-06 22:38                                       ` David Woodhouse
2007-02-06 22:39                                         ` Randy Dunlap
2007-02-06 23:11                                           ` Linus Torvalds
2007-02-06 23:15                                             ` Linus Torvalds
2007-02-06 23:18                                             ` David Woodhouse
2007-02-06 23:49                                               ` Linus Torvalds
2007-02-06 22:53                                         ` Linus Torvalds
2007-02-06 23:11                                           ` David Woodhouse
2007-02-06 23:28                                             ` Linus Torvalds
2007-02-06 23:36                                               ` David Woodhouse
2007-02-06 23:41                                                 ` Randy Dunlap
2007-02-06 23:49                                                   ` David Woodhouse
2007-02-06 23:52                                                   ` Robert P. J. Day
2007-02-06 23:55                                                 ` Linus Torvalds
2007-02-07  0:03                                                   ` David Woodhouse
2007-02-07  0:21                                                     ` Linus Torvalds
2007-02-07  0:30                                                       ` Randy Dunlap
2007-02-07  0:37                                                       ` David Woodhouse
2007-02-07  2:09                                                         ` Linus Torvalds
2007-02-07 13:51                                                       ` Sunil Naidu
2007-02-06  1:09                                 ` Theodore Tso
2007-02-06  6:09                                   ` Matt Mackall
2007-02-06 16:04                                     ` Bill Davidsen
2007-02-06 16:41                                       ` Matt Mackall
2007-02-06 18:03                                         ` Bill Davidsen
2007-02-06  0:00                               ` Jeff Garzik
2007-02-06 13:52                               ` Jörn Engel
2007-02-06 15:16                               ` Mark Lord
2007-02-08  8:18                                 ` David Lang
2007-02-08  9:44                                 ` Jörn Engel
2007-02-06 15:41                           ` Bill Davidsen
2007-02-05 22:21                       ` Alan
2007-02-05 22:35                         ` Linus Torvalds
2007-02-05 21:50                 ` Alan
2007-02-05 21:41                   ` David Woodhouse
2007-02-06  5:46                 ` Matt Mackall
2007-02-06 15:34                   ` Paul Mundt
2007-02-06 22:39                   ` Haavard Skinnemoen
2007-02-06 22:51                     ` Linus Torvalds
2007-02-05 16:33           ` David Woodhouse
2007-02-05 16:46           ` Russell King
2007-02-05 16:52             ` Ingo Molnar
2007-02-05 17:04               ` Russell King
2007-02-05 16:32     ` Linus Torvalds
2007-02-05 16:50       ` Russell King
2007-02-05 16:52       ` David Woodhouse
2007-02-05 17:58 ` Super Kernel Sunday! Jan Engelhardt
2007-02-05 18:07   ` Kevin Fox
2007-02-06 19:02   ` Stephen Hemminger
2007-02-05 21:27 ` [2.6.20] Regression in dmfe driver Thomas Bächler
2007-02-06  9:38   ` Thierry Vignaud
2007-02-06 22:40     ` Thomas Bächler
2007-02-27 13:58 ` [PATA] Failed to set xfermode on LITE-ON LTR-48246S Philipp Matthias Hahn
2007-03-05  4:10   ` Tejun Heo
2007-03-05 10:38     ` Philipp Matthias Hahn
2007-03-05 15:46       ` Tejun Heo
2007-03-06  9:23         ` Philipp Matthias Hahn
2007-03-09 12:50           ` Tejun Heo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Pine.LNX.4.64.0702051409110.8424@woody.linux-foundation.org \
    --to=torvalds@linux-foundation.org \
    --cc=dwmw2@infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    --subject='Re: [patch] MTD: fix DOC2000/2001/2001PLUS build error' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).