LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Roman Zippel <zippel@linux-m68k.org>
To: Oleg Verych <olecom@flower.upol.cz>
Cc: LKML <linux-kernel@vger.kernel.org>,
Andrew Morton <akpm@linux-foundation.org>,
Linus Torvalds <torvalds@linux-foundation.org>,
Jesper Juhl <jesper.juhl@gmail.com>,
Sam Ravnborg <sam@ravnborg.org>,
Horst Schirmeier <horst@schirmeier.com>,
Jan Beulich <jbeulich@novell.com>, Daniel Drake <dsd@gentoo.org>,
Andi Kleen <ak@suse.de>, Randy Dunlap <randy.dunlap@oracle.com>
Subject: Re: [patch 2/3, resend] kbuild: improve option checking, Kbuild.include cleanup
Date: Wed, 7 Feb 2007 15:36:47 +0100 (CET) [thread overview]
Message-ID: <Pine.LNX.4.64.0702071529390.14457@scrub.home> (raw)
In-Reply-To: <20070206012207.925430000@flower.upol.cz>
Hi,
On Tue, 6 Feb 2007, Oleg Verych wrote:
> -- all checks by shell united in one macro -- checker-shell;
> -- one disposable output sym. link to /dev/null per shell,
> thus no racing, `-Z' is removed;
> -- modules' build output directory is used, if supplied;
> -- every option checking function calls shell wrapper, acquires probe;
> -- `echo -e' bashizm substituted (people with sh != bash have distinct
> CC options!);
> -- some spelling and sense added to the comments;
> -- small shuffle of whitespace.
This patch is a bit overloaded and it would be better to split it up to
keep functional changes separate and then please drop the symlink, it has
no advantage to a simple temp file.
Also please don't add random whitespace, Makefiles are no C files, so
different rules apply.
bye, Roman
next prev parent reply other threads:[~2007-02-07 14:37 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-02-06 1:18 [patch 0/3, resend] scripts, kbuild updates/fixes (against 2.6.20) Oleg Verych
2007-02-06 1:18 ` [patch 1/3, resend] scripts: replace gawk, head, bc with shell, update Oleg Verych
2007-02-06 14:49 ` Mark Lord
2007-02-06 16:47 ` Oleg Verych
2007-02-06 17:13 ` Mark Lord
2007-02-07 8:58 ` Jesper Juhl
2007-02-07 13:02 ` Oleg Verych
2007-02-07 14:28 ` Roman Zippel
2007-02-06 1:18 ` [patch 2/3, resend] kbuild: improve option checking, Kbuild.include cleanup Oleg Verych
2007-02-07 14:36 ` Roman Zippel [this message]
2007-02-07 18:18 ` Oleg Verych
2007-02-07 20:14 ` Oleg Verych
2007-02-06 1:18 ` [patch 3/3, resend] kbuild: correctly skip tilded backups in localversion files Oleg Verych
2007-02-07 14:39 ` Roman Zippel
2007-02-07 18:03 ` Oleg Verych
2007-02-12 22:09 ` Tony Luck
2007-02-12 22:53 ` Linus Torvalds
2007-02-13 0:32 ` Oleg Verych
2007-02-13 5:05 ` Oleg Verych
2007-02-13 8:23 ` Gerd Hoffmann
2007-02-13 15:51 ` Linus Torvalds
2007-02-13 16:09 ` Roman Zippel
2007-02-14 1:16 ` kbuild, localversion (Re: [patch 3/3, resend] kbuild: correctly skip tilded backups in localversion files) Oleg Verych
2007-02-14 8:30 ` Sam Ravnborg
2007-02-06 17:56 ` [patch 0/3, resend] scripts, kbuild updates/fixes (against 2.6.20) Randy Dunlap
2007-02-06 18:25 ` Oleg Verych
2007-02-06 23:38 ` Oleg Verych
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Pine.LNX.4.64.0702071529390.14457@scrub.home \
--to=zippel@linux-m68k.org \
--cc=ak@suse.de \
--cc=akpm@linux-foundation.org \
--cc=dsd@gentoo.org \
--cc=horst@schirmeier.com \
--cc=jbeulich@novell.com \
--cc=jesper.juhl@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=olecom@flower.upol.cz \
--cc=randy.dunlap@oracle.com \
--cc=sam@ravnborg.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).