LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Linus Torvalds <torvalds@linux-foundation.org>
To: Roman Zippel <zippel@linux-m68k.org>
Cc: Oleg Verych <olecom@flower.upol.cz>,
	Alexey Dobriyan <adobriyan@gmail.com>,
	sam@ravnborg.org,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	Kai Germaschewski <kai@germaschewski.name>
Subject: Re: [patch, fix build regression] kbuild: Kbuild.include avoid using spaces in call arguments
Date: Wed, 7 Feb 2007 15:52:54 -0800 (PST)	[thread overview]
Message-ID: <Pine.LNX.4.64.0702071546420.8424@woody.linux-foundation.org> (raw)
In-Reply-To: <Pine.LNX.4.64.0702080029030.14457@scrub.home>



On Thu, 8 Feb 2007, Roman Zippel wrote:
> 
> Sorry, it needs more changes, the patch simply wasn't ready.

One problem I find very problematic with all the Kbuild setup is that 
people tend to be very quiet about any build issues until they simply go 
in.

Things don't "get ready" on their own. In other areas, people comment on 
why they don't like patches. In Kbuild, for some reason, we often seem to 
have this situation where people don't react at all.

Sam is great about maintaining the kernel build stuff most of the time, 
but because it's clearly a "secondary" thing, there tends to be some 
periods when nothing happens. Which is problematic for me..

So I end up in a situation where I just basically will apply the patches 
just becauseif I don't, nothing ever happens. The good news is that _once_ 
I apply them, people will usually notice problems and send in fixes fairly 
quickly. But this particular email was NOT useful, for example.  "needs 
more changes" is the epitome of a "not useful" comment.

I notice that Kai should probably have been Cc'd, and quite possibly 
wasn't. So I added him now.

In the meantime, I've applied the fixup patch. And more specific problem 
reports or patches are welcome.

		Linus

  parent reply	other threads:[~2007-02-07 23:53 UTC|newest]

Thread overview: 29+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-02-07 16:52 -mcpu strikes back Alexey Dobriyan
2007-02-07 17:47 ` Roman Zippel
2007-02-07 22:04   ` [patch, fix build regression] kbuild: Kbuild.include avoid using spaces in call arguments Oleg Verych
2007-02-07 23:34     ` Roman Zippel
2007-02-07 23:38       ` Randy Dunlap
2007-02-08  0:00         ` Roman Zippel
2007-02-08  1:20           ` discussion of Kbuild fixes (kbuild: Kbuild.include avoid using spaces in call arguments) Oleg Verych
2007-02-08  2:05             ` Roman Zippel
2007-02-08  2:59               ` Oleg Verych
2007-02-07 23:52       ` Linus Torvalds [this message]
2007-02-08  0:03         ` [patch, fix build regression] kbuild: Kbuild.include avoid using spaces in call arguments Roman Zippel
2007-02-08  4:30         ` Andrew Morton
2007-02-08  5:24           ` dd Oleg Verych
2007-02-08  5:19             ` dd Andrew Morton
2007-02-08  5:58               ` + search-a-little-harder-for-mkimage.patch Oleg Verych
2007-02-08  5:58                 ` Mike Frysinger
2007-02-08  6:43                   ` Oleg Verych
2007-02-08  6:42                     ` Mike Frysinger
2007-02-08 11:29                     ` Jan Engelhardt
2007-02-08 16:38                 ` Roman Zippel
2007-02-08 18:39                   ` Oleg Verych
2007-02-08  5:56             ` dd Mike Frysinger
2007-02-08  7:42               ` search-a-little-harder-for-mkimage.patch Oleg Verych
2007-02-08  7:40                 ` search-a-little-harder-for-mkimage.patch Mike Frysinger
2007-02-08  8:04                   ` search-a-little-harder-for-mkimage.patch Oleg Verych
2007-02-08  5:39           ` + make-mkcompile_h-use-lang=c-and-lc_all=c-for-cc-v.patch Oleg Verych
2007-02-08 16:34           ` [patch, fix build regression] kbuild: Kbuild.include avoid using spaces in call arguments Roman Zippel
     [not found]           ` <20070208064029.GO22699@flower.upol.cz>
     [not found]             ` <20070207224227.a23ca154.akpm@linux-foundation.org>
2007-02-23  0:02               ` .mailmap in top directory Oleg Verych
2007-02-08 15:48         ` [patch, fix build regression] kbuild: Kbuild.include avoid using spaces in call arguments Sam Ravnborg

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Pine.LNX.4.64.0702071546420.8424@woody.linux-foundation.org \
    --to=torvalds@linux-foundation.org \
    --cc=adobriyan@gmail.com \
    --cc=kai@germaschewski.name \
    --cc=linux-kernel@vger.kernel.org \
    --cc=olecom@flower.upol.cz \
    --cc=sam@ravnborg.org \
    --cc=zippel@linux-m68k.org \
    --subject='Re: [patch, fix build regression] kbuild: Kbuild.include avoid using spaces in call arguments' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).