LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Esben Nielsen <nielsen.esben@googlemail.com>
To: Randy Dunlap <randy.dunlap@oracle.com>
Cc: Esben Nielsen <nielsen.esben@googlemail.com>,
	Jeff Garzik <jeff@garzik.org>, Andrew Morton <akpm@osdl.org>,
	linux-kernel@vger.kernel.org, linux-net@vger.kernel.org
Subject: Re: [PATCH] Broken ArcNet com20020 pcmcia driver in 2.6.20
Date: Wed, 7 Feb 2007 23:24:21 +0100 (CET)	[thread overview]
Message-ID: <Pine.LNX.4.64.0702072315080.31566@frodo.shire> (raw)
In-Reply-To: <45CA0373.5080508@oracle.com>



On Wed, 7 Feb 2007, Randy Dunlap wrote:

> Esben Nielsen wrote:
>>  Hi,
>>  I can not get my com20020 pcmcia driver to work as a module under 2.6.20.
>>  There is the build problem:
>
> Please send me your .config file.  I can't seem to reproduce this.

The relevant parts:
...
CONFIG_ARCNET_COM20020=m
# CONFIG_ARCNET_COM20020_ISA is not set
# CONFIG_ARCNET_COM20020_PCI is not set
...
CONFIG_ARCNET_COM20020_CS=m

In this hiracy it is not nice for the com20020 module to check wether 
there are users for it. It breaks the direction of dependency. What if I 
first compile com20020 install it, and then decide I want one of the other
modules? Then would I have to recompile com20020 and reload it.
Therefore: Remove the check, do always export the symbols.

As for actually testing: I have access to ArcNet hardware for 3 more 
weeks. Then I will start at a new job, where there is no ArcNet.

Esben

>
>>  MODPOST 30 modules
>> WARNING:  "com20020_found" [drivers/net/pcmcia/com20020_cs.ko] undefined!
>> WARNING:  "com20020_check" [drivers/net/pcmcia/com20020_cs.ko] undefined!
>>
>>  The solution:
>>  Always export com20020_found and com20020_check.
>>
>>  Esben
>>
>>   drivers/net/arcnet/com20020.c |    3 ---
>>   1 file changed, 3 deletions(-)
>>
>>  Index: linux-2.6.20/drivers/net/arcnet/com20020.c
>>  ===================================================================
>>  --- linux-2.6.20.orig/drivers/net/arcnet/com20020.c
>>  +++ linux-2.6.20/drivers/net/arcnet/com20020.c
>>  @@ -337,11 +337,8 @@ static void com20020_set_mc_list(struct
>>       }
>>   }
>>
>>  -#if defined(CONFIG_ARCNET_COM20020_PCI_MODULE) || \
>>  -    defined(CONFIG_ARCNET_COM20020_ISA_MODULE)
>>   EXPORT_SYMBOL(com20020_check);
>>   EXPORT_SYMBOL(com20020_found);
>>  -#endif
>>
>>   MODULE_LICENSE("GPL");
>
> -- 
> ~ Randy
>

  reply	other threads:[~2007-02-07 22:24 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-02-07 14:16 Esben Nielsen
2007-02-07 16:50 ` Randy Dunlap
2007-02-07 22:24   ` Esben Nielsen [this message]
2007-02-07 22:58     ` Randy Dunlap

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Pine.LNX.4.64.0702072315080.31566@frodo.shire \
    --to=nielsen.esben@googlemail.com \
    --cc=akpm@osdl.org \
    --cc=jeff@garzik.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-net@vger.kernel.org \
    --cc=randy.dunlap@oracle.com \
    --subject='Re: [PATCH] Broken ArcNet com20020 pcmcia driver in 2.6.20' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).