LKML Archive on
help / color / mirror / Atom feed
From: Linus Torvalds <>
To: Roman Zippel <>
Cc:, Oleg Verych <>
Subject: Re: The who needs reviews anyways [PATCH]
Date: Thu, 8 Feb 2007 14:22:33 -0800 (PST)	[thread overview]
Message-ID: <> (raw)
In-Reply-To: <Pine.LNX.4.64.0702082227020.14457@scrub.home>

On Thu, 8 Feb 2007, Roman Zippel wrote:
> Sorry for the delay, but the git server were gone.
> - the define command is inappropriate (it's primarily for rule 
>   definitions)

Looks fine. Especially considering the strange whitespace issues.

> - execute commands in the current dir as all other commands
> - .*.tmp (but not .*.null) files are also removed up by "make clean"
> - printf has other side effects, instead stop pretending we support 
>   something else than bash

However, this one I have problems with .The problem is, many people 
probably _do_ have bash, but it's in /bin/sh. That used to be a fairly 
common setup a long time ago. Maybe it's not any more, but the whole "fall 
back to sh" actually came from that.

The $BASH variable is only defined if you use bash as your *interactive* 
shell, ie if you started "make" from a bash shell.

Historically, people used to do:
 - /bin/sh was the "standard shell" (bash)
 - /bin/[t]csh is what clueless weenies use for interactive work.

(Yeah, I'm not a [t]csh fan ;)

And you did break that.

It's quite possible that all modern distributions will install /bin/bash 
as a link to /bin/sh, but I don't see the point of that particular change. 
We aren't even all that bash-centric any more. If you have a 
POSIX-compatible shell in /bin/sh, it really _should_ work. It just can't 
be something really broken.

> - proper quoting
> - proper indentation

One thing I'm wondering about is whether we could have a "does this warn" 
test. I guess you can do it with -Werror, but it might be nice to have 
some tests for "does the -Wxyzzy flag warn also for proper code"


  parent reply	other threads:[~2007-02-08 22:22 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-02-08 21:48 The who needs reviews anyways [PATCH] Roman Zippel
2007-02-08 22:05 ` Sam Ravnborg
2007-02-08 22:22 ` Linus Torvalds [this message]
2007-02-08 22:53   ` Roman Zippel
2007-02-08 23:02     ` Linus Torvalds
2007-02-08 23:20       ` Roman Zippel
2007-02-09  2:29         ` Valdis.Kletnieks
2007-02-08 23:03 ` Kbuild refactoring (Re: The who needs reviews anyways [PATCH]) Oleg Verych
2007-02-09  0:06 ` The who needs reviews anyways [PATCH] Andreas Schwab
2007-02-09  1:21   ` Roman Zippel
2007-02-09  5:22 ` Oleg Verych
2007-02-09 11:35   ` Roman Zippel
2007-02-09 21:42     ` Oleg Verych

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \ \ \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).