LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Linus Torvalds <torvalds@linux-foundation.org>
To: Tony Luck <tony.luck@intel.com>
Cc: Oleg Verych <olecom@flower.upol.cz>,
LKML <linux-kernel@vger.kernel.org>,
Andrew Morton <akpm@linux-foundation.org>,
Jesper Juhl <jesper.juhl@gmail.com>,
Roman Zippel <zippel@linux-m68k.org>,
Bastian Blank <bastian@waldi.eu.org>,
Sam Ravnborg <sam@ravnborg.org>
Subject: Re: [patch 3/3, resend] kbuild: correctly skip tilded backups in localversion files
Date: Mon, 12 Feb 2007 14:53:29 -0800 (PST) [thread overview]
Message-ID: <Pine.LNX.4.64.0702121437420.8424@woody.linux-foundation.org> (raw)
In-Reply-To: <12c511ca0702121409t30e126dfh445d13dd2f637e08@mail.gmail.com>
On Mon, 12 Feb 2007, Tony Luck wrote:
>
> Git bisect fingers this patch (which is in Linus' tree as commit
> 76c329563c5b8663ef27eb1bd195885ab826cbd0) as the culprit
> for double adding the contents of the localversion file. E.g.
>
> $ echo -tiger-smp > localversion
> $ make prepare
> $ make kernelrelease
> 2.6.20-tiger-smp-tiger-smp
Heh. It's because we search for the localversion files in both $objtree
and $srctree, and normally they are one and the same - so it finds the
same file twice.
The old code did the same thing, but with the "make" $(sort ..) function,
which apparently removes duplicates. We should use "sort -u" here.
Both the old code *and* the new code is just horribly complex. The old
code appears to suffer from GNU $(wildcard ..), the new code is almost as
ugly in doing an unnecessarily complex "find".
Oh well.
Linus
next prev parent reply other threads:[~2007-02-12 22:53 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-02-06 1:18 [patch 0/3, resend] scripts, kbuild updates/fixes (against 2.6.20) Oleg Verych
2007-02-06 1:18 ` [patch 1/3, resend] scripts: replace gawk, head, bc with shell, update Oleg Verych
2007-02-06 14:49 ` Mark Lord
2007-02-06 16:47 ` Oleg Verych
2007-02-06 17:13 ` Mark Lord
2007-02-07 8:58 ` Jesper Juhl
2007-02-07 13:02 ` Oleg Verych
2007-02-07 14:28 ` Roman Zippel
2007-02-06 1:18 ` [patch 2/3, resend] kbuild: improve option checking, Kbuild.include cleanup Oleg Verych
2007-02-07 14:36 ` Roman Zippel
2007-02-07 18:18 ` Oleg Verych
2007-02-07 20:14 ` Oleg Verych
2007-02-06 1:18 ` [patch 3/3, resend] kbuild: correctly skip tilded backups in localversion files Oleg Verych
2007-02-07 14:39 ` Roman Zippel
2007-02-07 18:03 ` Oleg Verych
2007-02-12 22:09 ` Tony Luck
2007-02-12 22:53 ` Linus Torvalds [this message]
2007-02-13 0:32 ` Oleg Verych
2007-02-13 5:05 ` Oleg Verych
2007-02-13 8:23 ` Gerd Hoffmann
2007-02-13 15:51 ` Linus Torvalds
2007-02-13 16:09 ` Roman Zippel
2007-02-14 1:16 ` kbuild, localversion (Re: [patch 3/3, resend] kbuild: correctly skip tilded backups in localversion files) Oleg Verych
2007-02-14 8:30 ` Sam Ravnborg
2007-02-06 17:56 ` [patch 0/3, resend] scripts, kbuild updates/fixes (against 2.6.20) Randy Dunlap
2007-02-06 18:25 ` Oleg Verych
2007-02-06 23:38 ` Oleg Verych
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Pine.LNX.4.64.0702121437420.8424@woody.linux-foundation.org \
--to=torvalds@linux-foundation.org \
--cc=akpm@linux-foundation.org \
--cc=bastian@waldi.eu.org \
--cc=jesper.juhl@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=olecom@flower.upol.cz \
--cc=sam@ravnborg.org \
--cc=tony.luck@intel.com \
--cc=zippel@linux-m68k.org \
--subject='Re: [patch 3/3, resend] kbuild: correctly skip tilded backups in localversion files' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).