LKML Archive on
help / color / mirror / Atom feed
From: "Robert P. J. Day" <>
To: Linux kernel mailing list <>
Cc: Roman Zippel <>
Subject: [PATCH] Standardize on "depends on" in Kconfig files.
Date: Mon, 12 Feb 2007 16:41:05 -0500 (EST)	[thread overview]
Message-ID: <Pine.LNX.4.64.0702121635001.29808@CPE00045a9c397f-CM001225dbafb6> (raw)

  Standardize on "depends on" in Kconfig files, and drop support for
the alternative forms of "depends" or "requires".

Signed-off-by: Robert P. J. Day <>


  there was a consensus to standardize exclusively on the qualifier
"depends on" in Kconfig files, and i've had a patch in the system for
quite some time to take care of the three remaining files.  but not
only are those files still using the old form of "depends", now
there's another file that's *added* a few more instances.  grrrr.

  what about just dropping support in the kbuild structure?  *that*
would make sure things got cleaned up in a hurry.  this isn't perl --
it's not necessarily good that there's more than one way to do it.

 arch/arm/Kconfig         |    2 +-
 arch/arm/mm/Kconfig      |    2 +-
 arch/v850/Kconfig        |    2 +-
 sound/soc/codecs/Kconfig |    8 ++++----
 4 files changed, 7 insertions(+), 7 deletions(-)

diff --git a/arch/arm/Kconfig b/arch/arm/Kconfig
index 5c79519..77d062e 100644
--- a/arch/arm/Kconfig
+++ b/arch/arm/Kconfig
@@ -405,7 +405,7 @@ source arch/arm/mm/Kconfig

 config IWMMXT
 	bool "Enable iWMMXt support"
-	depends CPU_XSCALE || CPU_XSC3
+	depends on CPU_XSCALE || CPU_XSC3
 	default y if PXA27x
 	  Enable support for iWMMXt context switching at run time if
diff --git a/arch/arm/mm/Kconfig b/arch/arm/mm/Kconfig
index aade2f7..3c2f979 100644
--- a/arch/arm/mm/Kconfig
+++ b/arch/arm/mm/Kconfig
@@ -525,7 +525,7 @@ config CPU_BIG_ENDIAN
 	  of your chipset/board/processor.

-	depends !MMU && CPU_CP15 && !CPU_ARM740T
+	depends on !MMU && CPU_CP15 && !CPU_ARM740T
 	bool "Select the High exception vector"
 	default n
diff --git a/arch/v850/Kconfig b/arch/v850/Kconfig
index dbfab8f..50ccc7f 100644
--- a/arch/v850/Kconfig
+++ b/arch/v850/Kconfig
@@ -217,7 +217,7 @@ menu "Processor type and features"
    # Some platforms pre-zero memory, in which case the kernel doesn't need to
    config ZERO_BSS
-	  depends !V850E2_SIM85E2C
+	  depends on !V850E2_SIM85E2C
 	  default y

    # The crappy-ass zone allocator requires that the start of allocatable
diff --git a/sound/soc/codecs/Kconfig b/sound/soc/codecs/Kconfig
index 78ac268..ec2a278 100644
--- a/sound/soc/codecs/Kconfig
+++ b/sound/soc/codecs/Kconfig
@@ -1,15 +1,15 @@
 config SND_SOC_AC97_CODEC
-	depends SND_SOC
+	depends on SND_SOC

 config SND_SOC_WM8731
-	depends SND_SOC
+	depends on SND_SOC

 config SND_SOC_WM8750
-	depends SND_SOC
+	depends on SND_SOC

 config SND_SOC_WM9712
-	depends SND_SOC
+	depends on SND_SOC

Robert P. J. Day
Linux Consulting, Training and Annoying Kernel Pedantry
Waterloo, Ontario, CANADA

                 reply	other threads:[~2007-02-12 21:42 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Pine.LNX.4.64.0702121635001.29808@CPE00045a9c397f-CM001225dbafb6 \ \ \ \
    --subject='Re: [PATCH] Standardize on "depends on" in Kconfig files.' \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).