LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: James Morris <jmorris@namei.org>
To: David Miller <davem@davemloft.net>
Cc: latten@austin.ibm.com, ce@ruault.com,
	herbert@gondor.apana.org.au, linux-kernel@vger.kernel.org,
	linux-net@vger.kernel.org
Subject: Re: [BUG] 2.6.20 Oopses in xfrm_audit_log
Date: Mon, 12 Feb 2007 20:02:27 -0500 (EST)	[thread overview]
Message-ID: <Pine.LNX.4.64.0702122002030.30113@d.namei> (raw)
In-Reply-To: <20070212.134628.98748410.davem@davemloft.net>

On Mon, 12 Feb 2007, David Miller wrote:

> Thus, below is the patch I will use to fix this bug:
> 
> 1) Calling xfrm_audit_log() with a NULL object is a BUG()
> 2) Setting "result" based upon NULL'ness of the object makes no
>    sense, either set it to "1" in these cases or use an appropriate
>    error check.
> 
> How does this look to others?

Looks good to me.


-- 
James Morris
<jmorris@namei.org>

  reply	other threads:[~2007-02-13  1:02 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-02-12 17:44 Joy Latten
2007-02-12 20:50 ` [BUG] " David Miller
2007-02-12 21:04 ` Charles-Edouard Ruault
2007-02-12 21:46 ` David Miller
2007-02-13  1:02   ` James Morris [this message]
2007-02-15  8:22 ` Charles-Edouard Ruault
2007-02-26 10:36 ` Charles-Edouard Ruault
  -- strict thread matches above, loose matches on Subject: below --
2007-02-12 14:16 Charles-Edouard Ruault

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Pine.LNX.4.64.0702122002030.30113@d.namei \
    --to=jmorris@namei.org \
    --cc=ce@ruault.com \
    --cc=davem@davemloft.net \
    --cc=herbert@gondor.apana.org.au \
    --cc=latten@austin.ibm.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-net@vger.kernel.org \
    --subject='Re: [BUG] 2.6.20 Oopses in xfrm_audit_log' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).