LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Daniel Barkalow <barkalow@iabervon.org>
To: Chuck Ebbert <cebbert@redhat.com>
Cc: linux-kernel <linux-kernel@vger.kernel.org>,
	Dave Jones <davej@redhat.com>
Subject: Re: Is this bug too obvious?
Date: Tue, 13 Feb 2007 20:06:48 -0500 (EST)	[thread overview]
Message-ID: <Pine.LNX.4.64.0702132000220.20138@iabervon.org> (raw)
In-Reply-To: <45D25ABE.5080400@redhat.com>

On Tue, 13 Feb 2007, Chuck Ebbert wrote:

> drivers/usb/net/usbnet.c:
> 
> int
> usbnet_probe (struct usb_interface *udev, const struct usb_device_id *prod)
> {
>         struct usbnet                   *dev;
>         struct net_device               *net;
>         struct usb_host_interface       *interface;
>         struct driver_info              *info;
>         struct usb_device               *xdev;
>         int                             status;
> 
> 	...
> 
>         net = alloc_etherdev(sizeof(*dev));
>                                     ^^^^
> 	                            *net ???

No, alloc_etherdev takes the size of the private data, which, in this 
case, is *dev.

	-Daniel
*This .sig left intentionally blank*

  parent reply	other threads:[~2007-02-14  1:06 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-02-14  0:41 Chuck Ebbert
2007-02-14  0:49 ` Randy Dunlap
2007-02-14  1:06   ` [linux-usb-devel] " David Brownell
2007-02-14  1:06 ` Daniel Barkalow [this message]
2007-02-14  1:13   ` Chuck Ebbert
2007-02-16 22:34     ` usbnet/rndis (was: Is this bug too obvious?) Pete Zaitcev
2007-02-16 23:37       ` [linux-usb-devel] " David Brownell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Pine.LNX.4.64.0702132000220.20138@iabervon.org \
    --to=barkalow@iabervon.org \
    --cc=cebbert@redhat.com \
    --cc=davej@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --subject='Re: Is this bug too obvious?' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).