LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
* [PATCH] i810fb: Fix i810_check_params section mismatch
@ 2007-02-16 13:38 Jean Delvare
  2007-02-16 14:48 ` James Simmons
  0 siblings, 1 reply; 2+ messages in thread
From: Jean Delvare @ 2007-02-16 13:38 UTC (permalink / raw)
  To: Antonino Daplas; +Cc: LKML, Andrew Morton

WARNING: drivers/video/i810/i810fb.o - Section mismatch: reference
to .init.data: from .text between 'i810_check_params' (at offset
0x1123) and 'encode_fix'

yres cannot be declared __devinitdata as it is used in
i810_check_params(), which isn't __devinit.

Signed-off-by: Jean Delvare <khali@linux-fr.org>
---
This patch was already sent on December 17th, 2006.

 drivers/video/i810/i810_main.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

--- linux-2.6.20-rc1.orig/drivers/video/i810/i810_main.c	2006-12-17 16:02:06.000000000 +0100
+++ linux-2.6.20-rc1/drivers/video/i810/i810_main.c	2006-12-17 16:04:01.000000000 +0100
@@ -142,7 +142,7 @@
 static int vsync1     __devinitdata;
 static int vsync2     __devinitdata;
 static int xres       __devinitdata;
-static int yres       __devinitdata;
+static int yres;
 static int vyres      __devinitdata;
 static int sync       __devinitdata;
 static int extvga     __devinitdata;


-- 
Jean Delvare

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH] i810fb: Fix i810_check_params section mismatch
  2007-02-16 13:38 [PATCH] i810fb: Fix i810_check_params section mismatch Jean Delvare
@ 2007-02-16 14:48 ` James Simmons
  0 siblings, 0 replies; 2+ messages in thread
From: James Simmons @ 2007-02-16 14:48 UTC (permalink / raw)
  To: Jean Delvare; +Cc: Antonino Daplas, LKML, Andrew Morton



Andrew please apply.

Acked-By: James Simmons <jsimmons@infradead.org>

On Fri, 16 Feb 2007, Jean Delvare wrote:

> WARNING: drivers/video/i810/i810fb.o - Section mismatch: reference
> to .init.data: from .text between 'i810_check_params' (at offset
> 0x1123) and 'encode_fix'
> 
> yres cannot be declared __devinitdata as it is used in
> i810_check_params(), which isn't __devinit.
> 
> Signed-off-by: Jean Delvare <khali@linux-fr.org>
> ---
> This patch was already sent on December 17th, 2006.
> 
>  drivers/video/i810/i810_main.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> --- linux-2.6.20-rc1.orig/drivers/video/i810/i810_main.c	2006-12-17 16:02:06.000000000 +0100
> +++ linux-2.6.20-rc1/drivers/video/i810/i810_main.c	2006-12-17 16:04:01.000000000 +0100
> @@ -142,7 +142,7 @@
>  static int vsync1     __devinitdata;
>  static int vsync2     __devinitdata;
>  static int xres       __devinitdata;
> -static int yres       __devinitdata;
> +static int yres;
>  static int vyres      __devinitdata;
>  static int sync       __devinitdata;
>  static int extvga     __devinitdata;
> 
> 
> 

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2007-02-16 14:48 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2007-02-16 13:38 [PATCH] i810fb: Fix i810_check_params section mismatch Jean Delvare
2007-02-16 14:48 ` James Simmons

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).