LKML Archive on
help / color / mirror / Atom feed
From: Christoph Lameter <>
To: Rik van Riel <>
Cc: linux-kernel <>,
	linux-mm <>
Subject: Re: [PATCH] free swap space when (re)activating page
Date: Tue, 20 Feb 2007 10:20:06 -0800 (PST)	[thread overview]
Message-ID: <> (raw)
In-Reply-To: <>

On Tue, 20 Feb 2007, Rik van Riel wrote:

> Nono, I try to remove the swap space occupied by pages that
> go back onto the active list.  Regardless of whether they
> were already there, or whether they started out on the
> inactive list.

Ok then do it for all pages that go back not just for those leftover from 
the moving of pages to the inactive list (why would you move those???)

> Stripping the swap space of the pages that are going to
> the inactive list makes less sense IMHO, because those
> pages are candidates for swapping out - meaning those
> should keep the space.

Just trying to figure out what your patch does there and it does not make 
much sense to me so far.

Maybe the hunk does apply in a different location than I thought. If you 
do that in the loop over the pages on active list then it would make 
sense. But in that case you need another piece of it doing the same to the 
pages that are released at the end of shrink_active_list().

  reply	other threads:[~2007-02-20 18:20 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-02-16 22:46 Rik van Riel
2007-02-20  4:53 ` Christoph Lameter
2007-02-20 13:28   ` Rik van Riel
2007-02-20 16:37     ` Christoph Lameter
2007-02-20 16:46       ` Rik van Riel
2007-02-20 18:20         ` Christoph Lameter [this message]
2007-02-20 19:31           ` Rik van Riel
2007-02-20 19:42             ` Christoph Lameter
2007-02-20 19:54             ` Rik van Riel
2007-02-20 20:26               ` Christoph Lameter
2007-02-20 20:57               ` Christoph Lameter
2007-02-20 19:00 ` William Lee Irwin III
2007-02-21 15:09 Al Boldi
     [not found] <>
     [not found] ` <>
     [not found]   ` <>
     [not found]     ` <>
     [not found]       ` <>
     [not found]         ` <>
     [not found]           ` <>
     [not found]             ` <>
2007-02-23  1:44               ` Bodo Eggert
2007-02-23  3:34                 ` Rik van Riel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \ \ \
    --subject='Re: [PATCH] free swap space when (re)activating page' \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).