From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1030341AbXBTSUK (ORCPT ); Tue, 20 Feb 2007 13:20:10 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1030346AbXBTSUK (ORCPT ); Tue, 20 Feb 2007 13:20:10 -0500 Received: from netops-testserver-4-out.sgi.com ([192.48.171.29]:36991 "EHLO netops-testserver-4.corp.sgi.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1030341AbXBTSUI (ORCPT ); Tue, 20 Feb 2007 13:20:08 -0500 Date: Tue, 20 Feb 2007 10:20:06 -0800 (PST) From: Christoph Lameter To: Rik van Riel cc: linux-kernel , linux-mm Subject: Re: [PATCH] free swap space when (re)activating page In-Reply-To: <45DB25E1.7030504@redhat.com> Message-ID: References: <45D63445.5070005@redhat.com> <45DAF794.2000209@redhat.com> <45DB25E1.7030504@redhat.com> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 20 Feb 2007, Rik van Riel wrote: > Nono, I try to remove the swap space occupied by pages that > go back onto the active list. Regardless of whether they > were already there, or whether they started out on the > inactive list. Ok then do it for all pages that go back not just for those leftover from the moving of pages to the inactive list (why would you move those???) > Stripping the swap space of the pages that are going to > the inactive list makes less sense IMHO, because those > pages are candidates for swapping out - meaning those > should keep the space. Just trying to figure out what your patch does there and it does not make much sense to me so far. Maybe the hunk does apply in a different location than I thought. If you do that in the loop over the pages on active list then it would make sense. But in that case you need another piece of it doing the same to the pages that are released at the end of shrink_active_list().