LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: James Simmons <jsimmons@infradead.org>
To: Prarit Bhargava <prarit@redhat.com>
Cc: linux-kernel@vger.kernel.org, akpm@linux-foundation.org,
	linux-fbdev-devel@lists.sourceforge.net, adaplas@pol.net
Subject: Re: [PATCH]: change rivafb_remove to __devexit
Date: Wed, 21 Feb 2007 21:32:21 +0000 (GMT)	[thread overview]
Message-ID: <Pine.LNX.4.64.0702212131530.20620@pentafluge.infradead.org> (raw)
In-Reply-To: <20070220161306.23688.53776.sendpatchset@prarit.boston.redhat.com>


Acked-By: James Simmons <jsimmons@infradead.org>

On Tue, 20 Feb 2007, Prarit Bhargava wrote:

> Resubmitting with wider audience (akpm & lkml).
> 
> Change rivafb_remove to __deviexit to fix MODPOST warnings:
> 
> WARNING: drivers/video/riva/rivafb.o - Section mismatch: reference to
> .exit.text:rivafb_remove from .data.rel.local after 'rivafb_driver' (at offset 0x28)
> 
> Signed-off-by: Prarit Bhargava <prarit@redhat.com>
> 
> --- linux-2.6.19.ia64.orig/drivers/video/riva/fbdev.c	2007-02-07 09:56:37.000000000 -0500
> +++ linux-2.6.19.ia64/drivers/video/riva/fbdev.c	2007-02-08 11:39:35.000000000 -0500
> @@ -2154,7 +2154,7 @@ err_ret:
>  	return ret;
>  }
>  
> -static void __exit rivafb_remove(struct pci_dev *pd)
> +static void __devexit rivafb_remove(struct pci_dev *pd)
>  {
>  	struct fb_info *info = pci_get_drvdata(pd);
>  	struct riva_par *par = info->par;
> @@ -2232,7 +2232,7 @@ static struct pci_driver rivafb_driver =
>  	.name		= "rivafb",
>  	.id_table	= rivafb_pci_tbl,
>  	.probe		= rivafb_probe,
> -	.remove		= __exit_p(rivafb_remove),
> +	.remove		= __devexit_p(rivafb_remove),
>  };
>  
>  
> -
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at  http://www.tux.org/lkml/
> 

      reply	other threads:[~2007-02-21 21:32 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-02-20 16:13 Prarit Bhargava
2007-02-21 21:32 ` James Simmons [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Pine.LNX.4.64.0702212131530.20620@pentafluge.infradead.org \
    --to=jsimmons@infradead.org \
    --cc=adaplas@pol.net \
    --cc=akpm@linux-foundation.org \
    --cc=linux-fbdev-devel@lists.sourceforge.net \
    --cc=linux-kernel@vger.kernel.org \
    --cc=prarit@redhat.com \
    --subject='Re: [PATCH]: change rivafb_remove to __devexit' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).