LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: James Simmons <jsimmons@infradead.org>
To: Richard Purdie <rpurdie@rpsys.net>
Cc: Yaroslav Halchenko <lists@onerussian.com>,
Andrew Morton <akpm@linux-foundation.org>,
linux-kernel@vger.kernel.org,
linux-fbdev-devel@lists.sourceforge.net
Subject: Re: no backlight on radeon after recent kernel "upgrade"s
Date: Thu, 22 Feb 2007 15:18:25 +0000 (GMT) [thread overview]
Message-ID: <Pine.LNX.4.64.0702221502190.29542@pentafluge.infradead.org> (raw)
In-Reply-To: <1172137565.5837.24.camel@localhost.localdomain>
> > Ug. Previously it did the selecting for you. If you selected
> > backlight support the fbdev backlight would just come to life. This caused
> > problems for the case of having ACPI backlight and a fbdev driver with
> > backlight support. Two drivers controling the same hardware is not the
> > greatest idea. I made it so that people explictly had to pick the backlight
> > with a fbdev device. The other reason for this change was not every
> > one is using a LCD display. I have a system at home that uses a CRT.
> > Plus their is the case of "standard" PC graphics cards being used
> > in embedded devices. In this case even tho the graphics card has backlight
> > support the external lcd/backlight is routed through gpio independent of
> > the embedded graphics card. In such case we don't want to enable the
> > backlight for the graphics card but enable it.
> > In a nut shell the solution is select the backlight support for your
> > fbdev driver if you need it.
>
> This is ugly for distribution maintainers as pick the wrong Kconfig
> options and your device breaks. You need a different build depending on
> the hardware you have.
Distros would have to enable "standard" backlights to maximize their
target machines. In other words they will aim for backlights from the ACPI layer
for x86_64/ia32 machine and pmac_backlights for select ppc machines.
Specially since most default kernels on distros use only vgacon for intel
type machines.
> I understand some people need to be able to turn these things on but it
> sounds like the majority of users don't need it and it will break things
> for them. The config option sounds tempting to them though...
>
> In case anyone else is wondering, the commit in question is
> http://git.o-hand.com/?p=linux-rpurdie-backlight;a=commitdiff;h=e0e34ef7f02915cfe50e501e9f32c24217177a96
> and previously, all the appropriate entries had "depends PMAC_BACKLIGHT"
>
> I think the way forward is going to be to have the backlights disabled
> by default at runtime and require enabling through a framebuffer module
> parameter. The should be enabled by default in the PMAC_BACKLIGHT case.
> Anyone needing it can then pass the appropriate parameter. Does that
> sound like the best solution?
That is the correct solution. Basically people that select PMAC_BACKLIGHT
expect there driver to automatically to work. Basically they want
PMAC_BACKLIGHT to work as a generic selectfor there card. I will work up a
patch.
next prev parent reply other threads:[~2007-02-22 15:18 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-02-19 4:46 Yaroslav Halchenko
2007-02-19 8:04 ` Andrew Morton
2007-02-19 9:19 ` Richard Purdie
2007-02-21 5:56 ` Yaroslav Halchenko
2007-02-22 0:34 ` Richard Purdie
2007-02-22 1:07 ` James Simmons
2007-02-22 9:46 ` Richard Purdie
2007-02-22 15:18 ` James Simmons [this message]
2007-02-22 1:11 ` [Linux-fbdev-devel] " James Simmons
2007-02-22 2:09 ` Joel Becker
2007-02-22 15:55 ` James Simmons
2007-02-22 17:28 ` David Miller
2007-02-28 16:55 ` James Simmons
2007-03-01 10:57 ` Richard Purdie
2007-03-01 21:08 ` James Simmons
2007-02-21 22:18 ` Alex Romosan
2007-02-21 22:41 ` Richard Purdie
2007-02-21 23:17 ` Henrique de Moraes Holschuh
2007-02-22 0:12 ` Richard Purdie
2007-02-22 0:51 ` Henrique de Moraes Holschuh
2007-02-22 1:10 ` Richard Purdie
2007-02-22 2:13 ` Henrique de Moraes Holschuh
2007-02-22 1:10 ` Henrique de Moraes Holschuh
2007-02-22 1:16 ` ACPI: ibm-acpi: fix initial status of backlight device Henrique de Moraes Holschuh
2007-02-22 10:03 ` Richard Purdie
2007-02-22 14:45 ` Henrique de Moraes Holschuh
2007-02-22 18:19 ` Henrique de Moraes Holschuh
2007-02-22 10:00 ` no backlight on radeon after recent kernel "upgrade"s Richard Purdie
2007-02-22 14:56 ` Henrique de Moraes Holschuh
2007-02-22 15:19 ` Richard Purdie
2007-02-22 16:00 ` James Simmons
2007-02-22 16:34 ` Henrique de Moraes Holschuh
2007-02-22 17:08 ` Richard Purdie
2007-02-21 23:51 ` Alex Romosan
2007-02-22 1:13 ` James Simmons
2007-02-22 9:56 ` Richard Purdie
2007-02-22 14:38 ` Henrique de Moraes Holschuh
2007-02-22 4:03 ` Alex Romosan
2007-02-22 4:58 ` Alex Romosan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Pine.LNX.4.64.0702221502190.29542@pentafluge.infradead.org \
--to=jsimmons@infradead.org \
--cc=akpm@linux-foundation.org \
--cc=linux-fbdev-devel@lists.sourceforge.net \
--cc=linux-kernel@vger.kernel.org \
--cc=lists@onerussian.com \
--cc=rpurdie@rpsys.net \
--subject='Re: no backlight on radeon after recent kernel "upgrade"s' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).