LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Linus Torvalds <torvalds@linux-foundation.org>
To: Stephane Eranian <eranian@hpl.hp.com>
Cc: Jiri Slaby <jirislaby@gmail.com>, Uwe Bugla <uwe.bugla@gmx.de>,
	akpm@linux-foundation.org, bunk@stusta.de,
	linux-kernel@vger.kernel.org, Andi Kleen <ak@suse.de>,
	venkatesh.pallipadi@intel.com
Subject: Re: bug in kernel 2.6.21-rc1-git1: conventional floppy drive cannot be mounted without hanging up the whole system
Date: Mon, 26 Feb 2007 09:37:27 -0800 (PST)	[thread overview]
Message-ID: <Pine.LNX.4.64.0702260935010.12485@woody.linux-foundation.org> (raw)
In-Reply-To: <20070226172855.GB19403@frankl.hpl.hp.com>



On Mon, 26 Feb 2007, Stephane Eranian wrote:
> 
> The same code was used for i386 but I think for both architectures, the patch
> is missing default_idle(). I believe deault idle should look as follows:

Side note - I'll revert it regardless.

We can re-merge it later after

 - it has been tested better

 - people have added code to make all the expensive stuff go away if there 
   are no idle notifiers registered (ie "enter_idle" should NOT set the 
   idle-notify bit unconditionally in the idle loop, it should set if only 
   if there are people who care.

As it is, that patch was not only apparently buggy, but even if you fix 
the actual bug, it's still broken from a performance angle.

		Linus

  reply	other threads:[~2007-02-26 17:47 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-02-24 17:54 Uwe Bugla
2007-02-24 18:07 ` Andrew Morton
2007-02-24 18:29   ` Uwe Bugla
2007-02-24 19:23   ` Uwe Bugla
2007-02-24 19:49     ` Ray Lee
2007-02-26 10:38 ` Jiri Slaby
2007-02-26 15:12   ` Jiri Slaby
2007-02-26 15:51     ` Linus Torvalds
2007-02-26 16:28       ` Jiri Slaby
2007-02-26 16:34       ` Benjamin LaHaise
2007-02-26 17:10         ` Linus Torvalds
2007-02-26 17:45           ` Stephane Eranian
2007-02-26 17:28       ` Stephane Eranian
2007-02-26 17:37         ` Linus Torvalds [this message]
2007-02-25 18:29 Uwe Bugla
2007-02-25 21:04 ` Alexey Dobriyan
2007-02-26  3:55 ` Mike Galbraith
2007-02-26 18:06 Oleg Nesterov
2007-02-26 18:13 ` Linus Torvalds
2007-02-26 20:55   ` Rene Herman
2007-02-26 21:14     ` Linus Torvalds
2007-02-28  2:42       ` Bill Davidsen
2007-02-28 13:04         ` Alan
2007-02-28 12:20           ` Rene Herman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Pine.LNX.4.64.0702260935010.12485@woody.linux-foundation.org \
    --to=torvalds@linux-foundation.org \
    --cc=ak@suse.de \
    --cc=akpm@linux-foundation.org \
    --cc=bunk@stusta.de \
    --cc=eranian@hpl.hp.com \
    --cc=jirislaby@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=uwe.bugla@gmx.de \
    --cc=venkatesh.pallipadi@intel.com \
    --subject='Re: bug in kernel 2.6.21-rc1-git1: conventional floppy drive cannot be mounted without hanging up the whole system' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).