LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Linus Torvalds <torvalds@linux-foundation.org>
To: Oleg Nesterov <oleg@tv-sign.ru>
Cc: Stephane Eranian <eranian@hpl.hp.com>, linux-kernel@vger.kernel.org
Subject: Re: bug in kernel 2.6.21-rc1-git1: conventional floppy drive cannot be mounted without hanging up the whole system
Date: Mon, 26 Feb 2007 10:13:49 -0800 (PST)	[thread overview]
Message-ID: <Pine.LNX.4.64.0702261006440.12485@woody.linux-foundation.org> (raw)
In-Reply-To: <20070226180635.GA644@tv-sign.ru>



On Mon, 26 Feb 2007, Oleg Nesterov wrote:
> 
> I know nothing about floppy, but I guess the reason is floppy_disable_hlt().
> 
> Sorry for the offtopic question, is it really needed? According to grep, floppy
> is the only one user of disable_hlt().

I suspect you'd have a hard time finding a machine where it was broken any 
more.

But it used to be that the native (aka "braindamaged and idiotic") DMA by 
the motherboard southbridge chipset (and apparently _only_ that) had 
problems with the CPU being halted on some motherboards, and would corrupt 
data if the CPU was halted while the DMA took place.

We never bothered to even figure out why it happened, though. It was 
undeniable that there were people who had trouble with "hlt" and the 
floppy driver, but it is not clear what the cause was.

That's a _loong_ time ago, though, and it *probably* hasn't been an issue 
on any recent machine. People just don't care enough to test, especially 
since the upside is negligible, and the downside for when it would trigger 
is huge.

The floppy is still pretty much the only user of native motherboard (aka 
i8237) DMA'ing for most people. Some old ISA sound-cards may do it, of 
course. But any PCI device will do its own DMA rather than rely on the 
broken 8237 DMA engine, so for all I know, the bug - whatever it ever 
ended up being - could still be there.

			Linus

  reply	other threads:[~2007-02-26 18:20 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-02-26 18:06 Oleg Nesterov
2007-02-26 18:13 ` Linus Torvalds [this message]
2007-02-26 20:55   ` Rene Herman
2007-02-26 21:14     ` Linus Torvalds
2007-02-28  2:42       ` Bill Davidsen
2007-02-28 13:04         ` Alan
2007-02-28 12:20           ` Rene Herman
  -- strict thread matches above, loose matches on Subject: below --
2007-02-25 18:29 Uwe Bugla
2007-02-25 21:04 ` Alexey Dobriyan
2007-02-26  3:55 ` Mike Galbraith
2007-02-24 17:54 Uwe Bugla
2007-02-24 18:07 ` Andrew Morton
2007-02-24 18:29   ` Uwe Bugla
2007-02-24 19:23   ` Uwe Bugla
2007-02-24 19:49     ` Ray Lee
2007-02-26 10:38 ` Jiri Slaby
2007-02-26 15:12   ` Jiri Slaby
2007-02-26 15:51     ` Linus Torvalds
2007-02-26 16:28       ` Jiri Slaby
2007-02-26 16:34       ` Benjamin LaHaise
2007-02-26 17:10         ` Linus Torvalds
2007-02-26 17:45           ` Stephane Eranian
2007-02-26 17:28       ` Stephane Eranian
2007-02-26 17:37         ` Linus Torvalds

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Pine.LNX.4.64.0702261006440.12485@woody.linux-foundation.org \
    --to=torvalds@linux-foundation.org \
    --cc=eranian@hpl.hp.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=oleg@tv-sign.ru \
    --subject='Re: bug in kernel 2.6.21-rc1-git1: conventional floppy drive cannot be mounted without hanging up the whole system' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).