LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Davide Libenzi <davidel@xmailserver.org>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [patch] epoll reduced (to 1) number of passes over the ready set ...
Date: Mon, 26 Feb 2007 20:14:15 -0800 (PST)	[thread overview]
Message-ID: <Pine.LNX.4.64.0702262005440.10867@alien.or.mcafeemobile.com> (raw)
In-Reply-To: <Pine.LNX.4.64.0702261959260.12485@woody.linux-foundation.org>

On Mon, 26 Feb 2007, Linus Torvalds wrote:

> On Mon, 26 Feb 2007, Davide Libenzi wrote:
> > 
> > Epoll is doing multiple passes over the ready set at the moment, because 
> > of the constraints over the f_op->poll() call. Looking at the code again, 
> > I noticed that we already hold the epoll semaphore in read, and this 
> > (together with other locking conditions that hold while doing an 
> > epoll_wait()) can lead to a smarter way to "ship" events to userspace (in 
> > a single pass).
> 
> Ok, this looks fine, but I think it makes more sense with (a) a sign-off 
> line and perhaps a slightly expanded explanation, and (b) keeping it in 
> -mm until after 2.6.21 is out, and merging it then.
> 
> Yes? No? Linus is on some crazy drugs again?

Let me do more testing. My post was to have more eyes looking at it. Once 
I feel confident about it, and if no objections come from review, I'll 
sign and repost.



- Davide



  reply	other threads:[~2007-02-27  4:14 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-02-27  2:32 Davide Libenzi
2007-02-27  4:00 ` Linus Torvalds
2007-02-27  4:14   ` Davide Libenzi [this message]
2007-02-27  9:15 ` Eric Dumazet
2007-02-27 16:03   ` Davide Libenzi
2007-02-28 11:13     ` Eric Dumazet
2007-02-28 15:29       ` Davide Libenzi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Pine.LNX.4.64.0702262005440.10867@alien.or.mcafeemobile.com \
    --to=davidel@xmailserver.org \
    --cc=akpm@linux-foundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=torvalds@linux-foundation.org \
    --subject='Re: [patch] epoll reduced (to 1) number of passes over the ready set ...' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).