LKML Archive on
help / color / mirror / Atom feed
From: James Simmons <>
To: Andrew Morton <>
Subject: Re: [PATCH] display class
Date: Tue, 27 Feb 2007 21:46:42 +0000 (GMT)	[thread overview]
Message-ID: <> (raw)
In-Reply-To: <>

> this stuff looks el-crappo in an 80-col display.

Cleaning up....

> This guy can have static scope.
> It's a bit awkward having a fixed size.  I think lib/idr.c would suit for
> this.
> Also, we do set_bit() and clear_bit() on this, which are needlessly atomic. 
> If we hold a suitable lock then we can use __set_bit() and __clear_bit().
> And we do need a suitable lock.

Fixing... Never knew about idr. Hum nice :-) I will have a new patch your 
way. I just need to do some teste first.

> Why all the ifdeffery?  I think plain old
> static void __exit display_class_exit(void)
> {
> 	class_destroy(display_class);
> }
> module_exit(display_class_exit);
> module_init(display_class_init);

That is from the hunting of the bug with the broken symlinks in /sys. Will 
go back to sanity.

  reply	other threads:[~2007-02-27 21:46 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-02-25 18:39 James Simmons
2007-02-27 20:25 ` Andrew Morton
2007-02-27 21:46   ` James Simmons [this message]
2007-02-28 15:17   ` James Simmons

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \ \ \
    --subject='Re: [PATCH] display class' \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).