LKML Archive on lore.kernel.org help / color / mirror / Atom feed
From: Christoph Lameter <clameter@sgi.com> To: Matt Mackall <mpm@selenic.com> Cc: Pekka J Enberg <penberg@cs.helsinki.fi>, akpm@linux-foundation.org, ast@domdv.de, linux-kernel@vger.kernel.org Subject: Re: [PATCH] slab: deal with NULL pointers passed to kmem_cache_free Date: Mon, 19 Mar 2007 14:16:01 -0700 (PDT) [thread overview] Message-ID: <Pine.LNX.4.64.0703191414330.8328@schroedinger.engr.sgi.com> (raw) In-Reply-To: <20070319204945.GJ10459@waste.org> On Mon, 19 Mar 2007, Matt Mackall wrote: > I think this sort of thing should work: > > a = kmalloc(...) > b = kmem_cache_alloc(..) > c = allocate_some_id(...) > if (!a || !b || !c) { > free_some_id(c) > kmem_cache_free(c) ^^^^ this requires the specification of a kmem_cache structure and the object must be allocated by that cache. > kfree(a); Here we dynamically determine the slab cache and do not verify even which slab it came from. So you can always use kfree if you do not care. kmem_cache_free verifies correctness.
next prev parent reply other threads:[~2007-03-19 21:16 UTC|newest] Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top 2007-03-19 8:27 [PATCH] slab: deal with NULL pointers passed to kmem_cache_free Pekka J Enberg 2007-03-19 11:31 ` Andrew Morton 2007-03-19 11:40 ` Pekka J Enberg 2007-03-19 17:08 ` Christoph Lameter 2007-03-19 17:31 ` Pekka J Enberg 2007-03-19 20:49 ` Matt Mackall 2007-03-19 21:10 ` Andrew Morton 2007-03-19 21:25 ` Pekka Enberg 2007-03-19 21:41 ` Andrew Morton 2007-03-19 21:49 ` Matt Mackall 2007-03-20 7:06 ` Pekka Enberg 2007-03-20 18:41 ` Christoph Lameter 2007-03-21 11:42 ` Pekka J Enberg 2007-03-20 7:14 ` Pekka Enberg 2007-03-20 7:39 ` Eric Dumazet 2007-03-20 7:47 ` Pekka J Enberg 2007-03-20 7:56 ` Eric Dumazet 2007-03-21 10:11 ` Jarek Poplawski 2007-03-21 12:13 ` Pekka Enberg 2007-03-21 13:31 ` Jarek Poplawski 2007-03-21 13:36 ` Pekka J Enberg 2007-03-21 14:11 ` Rafael J. Wysocki 2007-03-21 14:41 ` Pekka Enberg 2007-03-21 16:30 ` Andrew Morton 2007-03-21 17:54 ` Jörn Engel 2007-03-21 18:32 ` Pekka Enberg 2007-03-21 14:45 ` Jarek Poplawski 2007-03-19 22:04 ` Jörn Engel 2007-03-19 21:16 ` Christoph Lameter [this message] 2007-03-19 21:44 ` Matt Mackall 2007-03-19 23:32 ` Andreas Steinmetz
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=Pine.LNX.4.64.0703191414330.8328@schroedinger.engr.sgi.com \ --to=clameter@sgi.com \ --cc=akpm@linux-foundation.org \ --cc=ast@domdv.de \ --cc=linux-kernel@vger.kernel.org \ --cc=mpm@selenic.com \ --cc=penberg@cs.helsinki.fi \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).