From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S964825AbXCYDiy (ORCPT ); Sat, 24 Mar 2007 23:38:54 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S933082AbXCYDix (ORCPT ); Sat, 24 Mar 2007 23:38:53 -0400 Received: from py-out-1112.google.com ([64.233.166.178]:22408 "EHLO py-out-1112.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932195AbXCYDix (ORCPT ); Sat, 24 Mar 2007 23:38:53 -0400 DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=beta; h=received:date:to:cc:subject:in-reply-to:message-id:references:mime-version:content-type:from; b=ipNCoG0jl0f0VgiAo1V/cgFg4QaD8neF/Q2nqUYjtqHkp/TjLKNErhD4XJ1JzLZIEdmnNZGdQPxpWpiaaqZJcOgw91Zp1C3mUh/AiEjyxhkJXtWK7ik9fjUgk064rjpoVfokwblzxQV5efLsxRX/oor9+15NzYZidh63C1rYgt8= Date: Sat, 24 Mar 2007 23:38:49 -0400 (EDT) To: linux-kernel@vger.kernel.org cc: akpm@linux-foundation.org, torvalds@linux-foundation.org, dmitry.torokhov@gmail.com Subject: Re: keyboard.c: Stop flooding dmesg with useless warnings In-Reply-To: Message-ID: References: MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII; format=flowed From: Parag Warudkar Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org > > Signed-off-by: Parag Warudkar > > --- linux-2.6-wk/drivers/char/keyboard.c 2007-03-24 23:01:19.000000000 > -0400 > +++ linux-2.6/drivers/char/keyboard.c 2007-03-24 21:43:58.000000000 -0400 > @@ -1161,7 +1161,7 @@ > > if ((raw_mode = (kbd->kbdmode == VC_RAW)) && !hw_raw) > if (emulate_raw(vc, keycode, !down << 7)) > - if (keycode < BTN_MISC && keycode != KEY_RESERVED) > + if (keycode < BTN_MISC) > printk(KERN_WARNING "keyboard.c: can't > emulate rawmode for keycode %d\n", keycode); > > #ifdef CONFIG_MAGIC_SYSRQ /* Handle the SysRq Hack */ > Yikes. Wrong one above. Right one below. Against latest git. I use Apple keyboard and mouse which seem to generate events with keycode==0. keyboard.c floods dmesg endlessly with below messages. This happens at a very fast rate and never stops, leaving the dmesg unusable. [46591.960000] keyboard.c: can't emulate rawmode for keycode 0 [46591.996000] keyboard.c: can't emulate rawmode for keycode 0 [46592.032000] keyboard.c: can't emulate rawmode for keycode 0 [46592.068000] keyboard.c: can't emulate rawmode for keycode 0 [46592.104000] keyboard.c: can't emulate rawmode for keycode 0 [46592.140000] keyboard.c: can't emulate rawmode for keycode 0 [46592.176000] keyboard.c: can't emulate rawmode for keycode 0 [46592.212000] keyboard.c: can't emulate rawmode for keycode 0 [46592.248000] keyboard.c: can't emulate rawmode for keycode 0 The patch below avoids printing the warning if keycode == KEY_RESERVED. If a more correct fix is possible please let me know and I will redo this. (I suspect avoiding call to emulate_raw() with value ranges it cannot emulate might be a better fix?) Signed-off-by: Parag Warudkar --- linux-2.6/drivers/char/keyboard.c 2007-03-24 21:43:58.000000000 -0400 +++ linux-2.6-wk/drivers/char/keyboard.c 2007-03-24 23:01:19.000000000 -0400 @@ -1161,7 +1161,7 @@ if ((raw_mode = (kbd->kbdmode == VC_RAW)) && !hw_raw) if (emulate_raw(vc, keycode, !down << 7)) - if (keycode < BTN_MISC) + if (keycode < BTN_MISC && keycode != KEY_RESERVED) printk(KERN_WARNING "keyboard.c: can't emulate rawmode for keycode %d\n", keycode); #ifdef CONFIG_MAGIC_SYSRQ /* Handle the SysRq Hack */