Re: [patch] sched: accurate user accounting

[malc <av1474@comtv.ru>]

On Sun, 25 Mar 2007, Con Kolivas wrote:

> On Sunday 25 March 2007 21:46, Con Kolivas wrote:
>> On Sunday 25 March 2007 21:34, malc wrote:
>>> On Sun, 25 Mar 2007, Ingo Molnar wrote:
>>>> * Con Kolivas <kernel@kolivas.org> wrote:
>>>>> For an rsdl 0.33 patched kernel. Comments? Overhead worth it?
>>>>
>>>> we want to do this - and we should do this to the vanilla scheduler
>>>> first and check the results. I've back-merged the patch to before RSDL
>>>> and have tested it - find the patch below. Vale, could you try this
>>>> patch against a 2.6.21-rc4-ish kernel and re-test your testcase?
>>>
>>> [..snip..]
>>>
>>> Compilation failed with:
>>> kernel/built-in.o(.sched.text+0x564): more undefined references to
>>> `__udivdi3' follow
>>>
>>> $ gcc --version | head -1
>>> gcc (GCC) 3.4.6
>>>
>>> $ cat /proc/cpuinfo | grep cpu
>>> cpu             : 7447A, altivec supported
>>>
>>> Can't say i really understand why 64bit arithmetics suddenly became an
>>> issue here.
>>
>> Probably due to use of:
>>
>> #define NS_TO_JIFFIES(TIME)	((TIME) / (1000000000 / HZ))
>> #define JIFFIES_TO_NS(TIME)	((TIME) * (1000000000 / HZ))
>>
>> Excuse our 64bit world while we strive to correct our 32bit blindness and
>> fix this bug.
>
> Please try this (akpm please don't include till we confirm it builds on ppc,
> sorry). For 2.6.21-rc4
>

Works. Accuracy is on par (most of the time with fraction of the
percent) with ad hoc method my kernel module employs. However there's
something strange happening w.r.t. iowait, it looks as if it doesn't
affect the idle field any more, nothing big but a digression from the
previous behavior. Thank you very much for this.

-- 
vale