LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Roman Zippel <zippel@linux-m68k.org>
To: Sam Ravnborg <sam@ravnborg.org>
Cc: Jan Beulich <jbeulich@novell.com>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] fix dependency generation
Date: Sat, 31 Mar 2007 18:11:36 +0200 (CEST)	[thread overview]
Message-ID: <Pine.LNX.4.64.0703311804230.14457@scrub.home> (raw)
In-Reply-To: <20070331064228.GA11023@uranus.ravnborg.org>

Hi,

On Sat, 31 Mar 2007, Sam Ravnborg wrote:

> The problem is that tristate symbol represent three values.
> =n => CONFIG_SYMBOL is undefined
> =y => CONFIG_SYMBOL is defined
> =m => COMFIG_SYMBOL_MODULE is defined
> 
> The function split_config does not take into account the
> different values and 'fixing' this in fixdep is wrong.
> Because fixdep does not know if the variable is a tristate symbol or not
> so it can either blindly remove _MODULE (your patch)
> or each time it encounters _MODULE check for a symbol with and
> without _MODULE.

What really matters is that CONFIG_SYMBOL changed, one could optimize for 
the COMFIG_SYMBOL_MODULE case, but I don't think it's worth it, especially 
...

> The better fix is to teach the split_config function that
> for tristate symbols two files shall be created in the include/config
> hirachy. So for apm this gets:
> include/config/apm.h
> include/config/apm/module.h

if it requires thousands of new inodes for a feature which should be 
rarely used.

> This will make kconfig behave correct the day that someone add a config
> symbol with a _MODULE suffix.

I'd rather reserve that namespace, if it allows for the simpler version to 
just map all symbols to the basic config symbol name.

bye, Roman

  parent reply	other threads:[~2007-03-31 16:12 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-03-29  9:27 Jan Beulich
2007-03-29 15:39 ` Randy Dunlap
2007-03-29 16:06   ` Jan Beulich
2007-03-29 16:38     ` Randy Dunlap
2007-03-30  9:14       ` Jan Beulich
2007-03-30 15:17         ` Randy Dunlap
2007-03-30 15:08 ` Sam Ravnborg
2007-03-30 15:43   ` Jan Beulich
2007-03-30 17:14     ` Jeff Dike
2007-03-31  6:42 ` Sam Ravnborg
2007-03-31  7:39   ` [PATCH 1/2] kconfig: factor out code in conf_spilt_config Sam Ravnborg
2007-03-31  7:40   ` [PATCH 2/2] kconfig/kbuild: fix dependency problem Sam Ravnborg
2007-03-31 16:11   ` Roman Zippel [this message]
2007-04-01 18:45     ` [PATCH] fix dependency generation Sam Ravnborg

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Pine.LNX.4.64.0703311804230.14457@scrub.home \
    --to=zippel@linux-m68k.org \
    --cc=jbeulich@novell.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=sam@ravnborg.org \
    --subject='Re: [PATCH] fix dependency generation' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).