LKML Archive on
help / color / mirror / Atom feed
From: "Robert P. J. Day" <>
To: James Bottomley <>
Cc: Adrian Bunk <>,
	Andrew Morton <>,,,
	Yokota Hiroshi <>,
	GOTO Masanori <>
Subject: Re: [2.6 patch] drivers/scsi/nsp32.c: remove kernel 2.4 code
Date: Fri, 27 Apr 2007 10:55:54 -0400 (EDT)	[thread overview]
Message-ID: <Pine.LNX.4.64.0704271051240.22643@localhost.localdomain> (raw)
In-Reply-To: <>

On Thu, 26 Apr 2007, James Bottomley wrote:

> Personally, I don't like to see 2.4 and 2.6 in a new driver, and
> will tend to try to force it to be 2.6 only.  For an existing
> driver, I tend to be much more tolerant: removing the huge gobs of
> code to achieve 2.6 only is usually a bit disruptive on both the
> driver and the maintainer
> > But if a driver is no longer actually maintained for both kernels
> > these checks become useless (and there quickly arised
> > unconditional 2.6-only code in such a driver) and can be removed.
> This driver is maintained by
> Yokota Hiroshi <>
> GOTO Masanori <>
> As it says in the header.  It was last modified in May 2006, so it
> is maintained under the somewhat elastic standards of SCSI.  I've
> cc'd them to see what they think.

while we're on the subject, what's the policy on supporting kernel
version selection *within* the 2.5 series?  as in:

$ grep -r "KERNEL_VERSION(2,5" *
drivers/scsi/pcmcia/nsp_cs.h:#if (LINUX_VERSION_CODE >= KERNEL_VERSION(2,5,74))
drivers/scsi/pcmcia/nsp_cs.c:#if (LINUX_VERSION_CODE < KERNEL_VERSION(2,5,0))
drivers/scsi/pcmcia/nsp_cs.c:#if (LINUX_VERSION_CODE < KERNEL_VERSION(2,5,2))
drivers/scsi/pcmcia/nsp_cs.c:#if (LINUX_VERSION_CODE > KERNEL_VERSION(2,5,73))
... etc etc ...

granted, this doesn't happen in a lot of files (almost of them
SCSI-related), but is it official policy to support code based on its
release number in the 2.5 series of releases?  unless you have a good
reason, wouldn't it make more sense to compare against (2,6,0) rather
than, say, (2,5,73)?  just an observation.


Robert P. J. Day
Linux Consulting, Training and Annoying Kernel Pedantry
Waterloo, Ontario, CANADA

  parent reply	other threads:[~2007-04-27 14:57 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-04-26 23:47 Adrian Bunk
2007-04-26 23:59 ` Robert P. J. Day
2007-04-27  0:13   ` Adrian Bunk
2007-04-27  0:30     ` James Bottomley
2007-04-27  4:26       ` GOTO Masanori
2007-04-27 14:55       ` Robert P. J. Day [this message]
2007-04-27 15:01         ` Adrian Bunk
  -- strict thread matches above, loose matches on Subject: below --
2007-03-26  4:08 Adrian Bunk

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Pine.LNX.4.64.0704271051240.22643@localhost.localdomain \ \ \ \ \ \ \ \ \
    --subject='Re: [2.6 patch] drivers/scsi/nsp32.c: remove kernel 2.4 code' \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).