LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Paul Walmsley <paul@booyaka.com>
To: Jiri Kosina <jkosina@suse.cz>
Cc: Greg KH <greg@kroah.com>, "VE \(HOME\)" <ve@vetienne.net>,
	Andrew Morton <akpm@linux-foundation.org>,
	Linux Kernel <linux-kernel@vger.kernel.org>,
	fubar@us.ibm.com
Subject: Re: USB HID bug (was [PROBLEM] Bonding driver in linux-2.6.21-rc6-mm1)
Date: Fri, 27 Apr 2007 17:24:24 -0600 (MDT)	[thread overview]
Message-ID: <Pine.LNX.4.64.0704271651260.21519@utopia.booyaka.com> (raw)
In-Reply-To: <Pine.LNX.4.64.0704280024170.7370@jikos.suse.cz>

Hi Jiri,

On Sat, 28 Apr 2007, Jiri Kosina wrote:

> Paul, do you have any idea? In fact, what was your reason for putting this
> WARN_ON() there?

The static quirk list uses idVendor == 0 to mark the end of 
hid_blacklist[], so we don't expect any device to have idVendor == 0.  If 
a device is correctly presenting with idVendor == 0, we need a different 
way to terminate that blacklist.  Either that or there's an upper-layer 
bug, as you write.

Regarding its placement: that WARN_ON() belongs in the static quirk lookup 
code, rather than where it is now.  Its current location must be a relic 
of an earlier patchset.

> Did you ever meet any condition when idVendor == 0 appears there?

No.  There shouldn't be any functional problem with removing that 
WARN_ON(), and also removing the initial if() in usbhid_lookup_dquirk().


- Paul

  parent reply	other threads:[~2007-04-27 23:24 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-04-26 18:58 [PROBLEM] Bonding driver in linux-2.6.21-rc6-mm1 Vincent ETIENNE
2007-04-26 20:27 ` Chris Snook
2007-04-26 20:44   ` [Bonding-devel] " Jay Vosburgh
2007-04-26 21:43     ` Vincent ETIENNE
2007-05-09 18:47     ` Vincent ETIENNE
2007-04-27  4:11 ` Andrew Morton
2007-04-27  9:25   ` VE (HOME)
2007-04-27 19:20     ` Andrew Morton
2007-04-27 21:18     ` USB HID bug (was [PROBLEM] Bonding driver in linux-2.6.21-rc6-mm1) Greg KH
2007-04-27 22:42       ` Jiri Kosina
2007-04-27 22:55         ` Jiri Kosina
2007-04-27 23:24         ` Paul Walmsley [this message]
2007-04-28  7:21         ` Vincent ETIENNE
2007-04-28 14:07           ` Paul Walmsley
2007-04-28 15:06           ` Jiri Kosina
2007-04-28 19:50             ` [linux-usb-devel] " Alan Stern
2007-04-28 20:43               ` Vincent ETIENNE
2007-04-29 11:18                 ` Jiri Kosina
2007-04-29 13:40                   ` Vincent ETIENNE
     [not found] ` <200704272205.29131.ve@vetienne.net>
     [not found]   ` <20070427153237.03f3b59c.akpm@linux-foundation.org>
2007-04-28 21:10     ` [PROBLEM] Bonding driver in linux-2.6.21-rc6-mm1 Vincent ETIENNE

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Pine.LNX.4.64.0704271651260.21519@utopia.booyaka.com \
    --to=paul@booyaka.com \
    --cc=akpm@linux-foundation.org \
    --cc=fubar@us.ibm.com \
    --cc=greg@kroah.com \
    --cc=jkosina@suse.cz \
    --cc=linux-kernel@vger.kernel.org \
    --cc=ve@vetienne.net \
    --subject='Re: USB HID bug (was [PROBLEM] Bonding driver in linux-2.6.21-rc6-mm1)' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).