LKML Archive on
help / color / mirror / Atom feed
From: Hugh Dickins <>
To: Andrew Morton <>
Cc: Matt Mackall <>, Alexey Dobriyan <>,,
	Nick Piggin <>
Subject: Re: - maps2-add-proc-pid-pagemap-interface-fix.patch removed from -mm tree
Date: Sat, 28 Apr 2007 06:13:39 +0100 (BST)	[thread overview]
Message-ID: <> (raw)
In-Reply-To: <>

On Fri, 27 Apr 2007, Andrew Morton wrote:
> hm, could do.  might_sleep() is intertwined with preempt in complex ways,
> but we did decouple that at the config level.  no_mmap_sem() will dtrt for
> all preempt settings.
> But I'll be keeping this as a -mm-only debug patch (which brings us up to
> about thirty of 'em), so I think it's best to make it unconfigurable so we
> get maximum coverage.
> That's if it actually works.  I haven't tried running it yet, and I have a
> feeling that running it might cause a big "doh" moment.  We'll see.

Yes, I'm expecting the crucial

> +	WARN_ON(rwsem_is_locked(&mm->mmap_sem))

to give a bogus warning every time another thread (or /proc,
or swapoff, or whatever) happens to have this mmap_sem locked.
might_sleep() is quite different, works on our thread's info.


  reply	other threads:[~2007-04-28  5:23 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <>
2007-04-27 10:45 ` Alexey Dobriyan
2007-04-27 20:27   ` Andrew Morton
2007-04-27 20:41     ` Matt Mackall
2007-04-27 21:31       ` Andrew Morton
2007-04-28  5:13         ` Hugh Dickins [this message]
2007-04-28  5:48           ` Andrew Morton

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \ \ \ \ \
    --subject='Re: - maps2-add-proc-pid-pagemap-interface-fix.patch removed from -mm tree' \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).