LKML Archive on
help / color / mirror / Atom feed
From: "Robert P. J. Day" <>
To: Linux Kernel Mailing List <>
Cc: Andrew Morton <>
Subject: Remove apparently dead CONFIG_NO_ATA_LEGACY code.
Date: Thu, 3 May 2007 13:53:06 -0400 (EDT)	[thread overview]
Message-ID: <Pine.LNX.4.64.0705031350550.11235@localhost.localdomain> (raw)

Remove the single snippet of code conditional on the non-existent
CONFIG_NO_ATA_LEGACY Kconfig variable.

Signed-off-by: Robert P. J. Day <>


  i would have mailed a note about this to the ATA maintainer but it
wasn't clear who that was.  this is the only dead CONFIG_ variable
under drivers/ata so i figured i'd just submit the patch.

diff --git a/drivers/ata/libata-sff.c b/drivers/ata/libata-sff.c
index d211db6..5a4821a 100644
--- a/drivers/ata/libata-sff.c
+++ b/drivers/ata/libata-sff.c
@@ -985,16 +985,6 @@ int ata_pci_init_one (struct pci_dev *pdev, struct ata_port_info **port_info,
 		mask = (1 << 2) | (1 << 0);
 		if ((tmp8 & mask) != mask)
 			legacy_mode = (1 << 3);
-#if defined(CONFIG_NO_ATA_LEGACY)
-		/* Some platforms with PCI limits cannot address compat
-		   port space. In that case we punt if their firmware has
-		   left a device in compatibility mode */
-		if (legacy_mode) {
-			printk(KERN_ERR "ata: Compatibility mode ATA is not supported on this platform, skipping.\n");
-			rc = -EOPNOTSUPP;
-			goto err_out;
-		}

 	/* alloc and init host */
Robert P. J. Day
Linux Consulting, Training and Annoying Kernel Pedantry
Waterloo, Ontario, CANADA

             reply	other threads:[~2007-05-03 17:55 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-05-03 17:53 Robert P. J. Day [this message]
2007-05-03 18:16 ` Randy Dunlap
2007-05-03 21:17 ` Alan Cox

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Pine.LNX.4.64.0705031350550.11235@localhost.localdomain \ \ \ \
    --subject='Re: Remove apparently dead CONFIG_NO_ATA_LEGACY code.' \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).