LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Cal Peake <cp@absolutedigital.net>
To: Andi Kleen <ak@suse.de>
Cc: Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] drop unneeded variable in amd_apic_timer_broken
Date: Wed, 8 Aug 2007 12:00:31 -0400 (EDT) [thread overview]
Message-ID: <Pine.LNX.4.64.0708081146120.25865@lancer.cnet.absolutedigital.net> (raw)
In-Reply-To: <200708081636.20223.ak@suse.de>
On Wed, 8 Aug 2007, Andi Kleen wrote:
> Can you please test if this patch works?
Yep, seems to do the trick. Thanks!
> BTW I checked with AMD and they seem to think it's just a buggy BIOS.
Nod. Atleast we can work around it.
> Use global flag to disable broken local apic timer on AMD CPUs.
>
> The Averatec 2370 laptop BIOS seems to program the ENABLE_C1E
s~2370~2370/2371~ to be completely accurate ;)
> MSR inconsistently between cores. This confuses the lapic
> use heuristics wants to know if C1E is enabled anywhere.
>
> Use a global flag instead of a per cpu flag to handle this.
> If any CPU has C1E enabled disabled lapic use.
>
> Thanks to Cal Peake for debugging.
> Signed-off-by: Andi Kleen <ak@suse.de>
Acked-by: Cal Peake <cp@absolutedigital.net>
--
Cal Peake
next prev parent reply other threads:[~2007-08-08 16:00 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-07-29 18:05 ACPI on Averatec 2370 Frank Hale
2007-07-29 18:13 ` Gabriel C
2007-07-29 18:45 ` Cal Peake
2007-07-29 18:58 ` Frank Hale
2007-07-29 19:58 ` Frank Hale
2007-07-30 15:20 ` Cal Peake
2007-08-02 17:50 ` Cal Peake
2007-08-02 19:09 ` Chuck Ebbert
2007-08-02 19:42 ` Cal Peake
2007-08-02 20:26 ` Chuck Ebbert
2007-08-02 20:30 ` Cal Peake
2007-08-02 20:51 ` Frank Hale
2007-08-02 21:07 ` Linus Torvalds
2007-08-02 21:53 ` Cal Peake
2007-08-03 21:56 ` Linus Torvalds
2007-08-04 9:30 ` Andi Kleen
2007-08-04 13:50 ` Frank Hale
2007-08-05 14:26 ` Thomas Renninger
2007-08-07 22:15 ` Cal Peake
2007-08-08 0:06 ` Andi Kleen
2007-08-08 0:53 ` [PATCH] drop unneeded variable in amd_apic_timer_broken Cal Peake
2007-08-08 14:36 ` Andi Kleen
2007-08-08 16:00 ` Cal Peake [this message]
2007-08-08 18:25 ` Tim Gardner
2007-08-08 14:41 ` ACPI on Averatec 2370 Joachim Deguara
2007-08-08 23:52 ` Frank Hale
2007-08-09 9:45 ` Joachim Deguara
2007-08-03 15:52 ` Ben Collins
2007-08-03 18:19 ` Chuck Ebbert
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Pine.LNX.4.64.0708081146120.25865@lancer.cnet.absolutedigital.net \
--to=cp@absolutedigital.net \
--cc=ak@suse.de \
--cc=linux-kernel@vger.kernel.org \
--subject='Re: [PATCH] drop unneeded variable in amd_apic_timer_broken' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).