LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Jan Engelhardt <jengelh@computergmbh.de>
To: Joe Perches <joe@perches.com>
Cc: Pavel Emelyanov <xemul@openvz.org>, Andrew Morton <akpm@osdl.org>,
	Alexey Dobriyan <adobriyan@openvz.org>,
	Linux Containers <containers@lists.osdl.org>,
	linux-arch@vger.kernel.org,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	Sukadev Bhattiprolu <sukadev@us.ibm.com>,
	Oleg Nesterov <oleg@tv-sign.ru>
Subject: Re: [PATCH] Use helpers to obtain task pid in printks (arch code)
Date: Thu, 30 Aug 2007 21:11:05 +0200 (CEST)	[thread overview]
Message-ID: <Pine.LNX.4.64.0708302107510.24730@fbirervta.pbzchgretzou.qr> (raw)
In-Reply-To: <1188237708.18004.102.camel@localhost>


On Aug 27 2007 11:01, Joe Perches wrote:
>On Mon, 2007-08-27 at 11:30 +0400, Pavel Emelyanov wrote:
>> From: Alexey Dobriyan <adobriyan@openvz.org>
>> 
>> One of the easiest things to isolate is the pid printed in kernel
>> log. There was a patch, that made this for arch-independent code,
>> this one makes so for arch/xxx files.
>
>Perhaps it would be worthwhile to standardize the printk
>task information content? Maybe a format knob?
>
>Maybe TASK_FMT/TASK_ARG(task)
>
>#define TASK_FMT "%s"
>#define TASK_ARG(tsk) ({char __buf[MAX_TASK_INFO]; print_task(tsk, buf, sizeof(__buf)); __buf})

Except that __buf goes out of scope before printk() is called...



	Jan
-- 

      reply	other threads:[~2007-08-30 19:11 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-08-27  7:30 Pavel Emelyanov
2007-08-27 18:01 ` Joe Perches
2007-08-30 19:11   ` Jan Engelhardt [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Pine.LNX.4.64.0708302107510.24730@fbirervta.pbzchgretzou.qr \
    --to=jengelh@computergmbh.de \
    --cc=adobriyan@openvz.org \
    --cc=akpm@osdl.org \
    --cc=containers@lists.osdl.org \
    --cc=joe@perches.com \
    --cc=linux-arch@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=oleg@tv-sign.ru \
    --cc=sukadev@us.ibm.com \
    --cc=xemul@openvz.org \
    --subject='Re: [PATCH] Use helpers to obtain task pid in printks (arch code)' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).