From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752252AbYANTRJ (ORCPT ); Mon, 14 Jan 2008 14:17:09 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751084AbYANTQ5 (ORCPT ); Mon, 14 Jan 2008 14:16:57 -0500 Received: from relay2.sgi.com ([192.48.171.30]:51923 "EHLO relay.sgi.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751022AbYANTQ5 (ORCPT ); Mon, 14 Jan 2008 14:16:57 -0500 Date: Mon, 14 Jan 2008 11:16:56 -0800 (PST) From: Christoph Lameter X-X-Sender: clameter@schroedinger.engr.sgi.com To: Mike Travis cc: Jan Engelhardt , Andrew Morton , Andi Kleen , mingo@elte.hu, Jack Steiner , linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 01/10] x86: Change size of APICIDs from u8 to u16 In-Reply-To: <478BAAD5.1090500@sgi.com> Message-ID: References: <20080113183453.973425000@sgi.com> <20080113183454.155968000@sgi.com> <478BAAD5.1090500@sgi.com> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 14 Jan 2008, Mike Travis wrote: > I see the mistake in the node array. But AFAICT, pxm is the proximity > between nodes and cannot be expressed as greater than the number of > nodes, yes? (Or can it be arbitrarily expressed where 32 bits is > necessary?) I ask this because the real node_to_pxm_map is already > 32 bits. Well I think local variables that contain a node can be int without a problem because that is what the core used to store node ids.