LKML Archive on
help / color / mirror / Atom feed
From: Roman Zippel <>
To: Jan Beulich <>
Cc: Randy Dunlap <>,,
Subject: Re: non-choice related config entries within choice
Date: Sat, 19 Jan 2008 05:36:47 +0100 (CET)	[thread overview]
Message-ID: <Pine.LNX.4.64.0801171803000.17507@scrub.home> (raw)
In-Reply-To: <>


On Wed, 16 Jan 2008, Jan Beulich wrote:

> now that I finally found time to look into the problems that caused the
> patch changing boolean/tristate choice behavior to be reverted I find
> that due to the way things worked in the past there are a couple of
> cases where config options not really belonging to the choice are inside
> the choice scope (drivers/usb/gadget/Kconfig, arch/ppc/Kconfig, and
> arch/mips/Kconfig are where I found such cases, and I hope this is a
> complete list).
> The question is: Is it intended for this to work the way it used to, or
> is it rather reasonable to change these scripts so that stuff dependent
> upon the choice selection is being dealt with outside the choice scope?

This is really a feature, try it with a visible option there which depends 
on a choice option.
First for the choice type I think it's simpler to just look at the first 
choice option, anything more complex simply has to specify the type 

The bigger problem is that menu_finalize() is little complex which makes 
such changes more difficult, basically it does two things (updating the 
dependencies and generating the menu structure) in one pass and it depends 
on a specific order, which is nonobvious. I really should clean this up to 
make it easier to follow what's happening.
For now this means the dependency to the choice symbol has to be added a 
little later right before the call to menu_add_symbol().

bye, Roman

      parent reply	other threads:[~2008-01-19  4:37 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-01-16 11:18 Jan Beulich
2008-01-16 11:52 ` Sam Ravnborg
2008-01-16 13:46   ` Jan Beulich
2008-01-16 13:50     ` Sam Ravnborg
2008-01-19  4:44   ` Roman Zippel
2008-01-19  4:36 ` Roman Zippel [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Pine.LNX.4.64.0801171803000.17507@scrub.home \ \ \ \ \ \
    --subject='Re: non-choice related config entries within choice' \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).