LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
* [PATCH] linux/types.h: always export 64bit aligned defines
@ 2008-01-26  9:23 Mike Frysinger
  2008-01-28  5:33 ` Andrew Morton
  0 siblings, 1 reply; 5+ messages in thread
From: Mike Frysinger @ 2008-01-26  9:23 UTC (permalink / raw)
  To: Andrew Morton, LKML

Some kernel headers exported to userspace rely on these 64bit aligned defines.
However, they are hidden behind __KERNEL_STRICT_NAMES at the moment which
means most of the time, they're never actually available.  These these defines
dont actually conflict with normal userspace / C library types, there's no
reason to hide them behind the __KERNEL_STRICT_NAMES define.

Signed-off-by: Mike Frysinger <vapier@gentoo.org>
---
 include/linux/types.h |   10 +++++-----
 1 files changed, 5 insertions(+), 5 deletions(-)

diff --git a/include/linux/types.h b/include/linux/types.h
index f4f8d19..b80a263 100644
--- a/include/linux/types.h
+++ b/include/linux/types.h
@@ -125,11 +125,6 @@ typedef		__u64		u_int64_t;
 typedef		__s64		int64_t;
 #endif
 
-/* this is a special 64bit data type that is 8-byte aligned */
-#define aligned_u64 unsigned long long __attribute__((aligned(8)))
-#define aligned_be64 __be64 __attribute__((aligned(8)))
-#define aligned_le64 __le64 __attribute__((aligned(8)))
-
 /**
  * The type used for indexing onto a disc or disc partition.
  *
@@ -161,6 +156,11 @@ typedef unsigned long blkcnt_t;
 
 #endif /* __KERNEL_STRICT_NAMES */
 
+/* this is a special 64bit data type that is 8-byte aligned */
+#define aligned_u64 unsigned long long __attribute__((aligned(8)))
+#define aligned_be64 __be64 __attribute__((aligned(8)))
+#define aligned_le64 __le64 __attribute__((aligned(8)))
+
 /*
  * Below are truly Linux-specific types that should never collide with
  * any application/library that wants linux/types.h.
-- 
1.5.3.8

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH] linux/types.h: always export 64bit aligned defines
  2008-01-26  9:23 [PATCH] linux/types.h: always export 64bit aligned defines Mike Frysinger
@ 2008-01-28  5:33 ` Andrew Morton
  2008-01-29 19:43   ` Jan Engelhardt
  0 siblings, 1 reply; 5+ messages in thread
From: Andrew Morton @ 2008-01-28  5:33 UTC (permalink / raw)
  To: Mike Frysinger; +Cc: LKML, Sam Ravnborg, David Woodhouse

On Sat, 26 Jan 2008 04:23:21 -0500 Mike Frysinger <vapier@gentoo.org> wrote:

> Some kernel headers exported to userspace rely on these 64bit aligned defines.
> However, they are hidden behind __KERNEL_STRICT_NAMES at the moment which
> means most of the time, they're never actually available.  These these defines
> dont actually conflict with normal userspace / C library types, there's no
> reason to hide them behind the __KERNEL_STRICT_NAMES define.
> 

Maybe we shouldn't be using these helper macros in exported-to-userspace
headers.  Do you know which headers are affected?  Did you consider jsut
expanding the macros in situ for thse cases?


> ---
>  include/linux/types.h |   10 +++++-----
>  1 files changed, 5 insertions(+), 5 deletions(-)
> 
> diff --git a/include/linux/types.h b/include/linux/types.h
> index f4f8d19..b80a263 100644
> --- a/include/linux/types.h
> +++ b/include/linux/types.h
> @@ -125,11 +125,6 @@ typedef		__u64		u_int64_t;
>  typedef		__s64		int64_t;
>  #endif
>  
> -/* this is a special 64bit data type that is 8-byte aligned */
> -#define aligned_u64 unsigned long long __attribute__((aligned(8)))
> -#define aligned_be64 __be64 __attribute__((aligned(8)))
> -#define aligned_le64 __le64 __attribute__((aligned(8)))
> -
>  /**
>   * The type used for indexing onto a disc or disc partition.
>   *
> @@ -161,6 +156,11 @@ typedef unsigned long blkcnt_t;
>  
>  #endif /* __KERNEL_STRICT_NAMES */
>  
> +/* this is a special 64bit data type that is 8-byte aligned */
> +#define aligned_u64 unsigned long long __attribute__((aligned(8)))
> +#define aligned_be64 __be64 __attribute__((aligned(8)))
> +#define aligned_le64 __le64 __attribute__((aligned(8)))
> +
>  /*
>   * Below are truly Linux-specific types that should never collide with
>   * any application/library that wants linux/types.h.

Seems relatively harmless.

But I'd have thought that if we're going to do this, we should create a
standard naming convention for types which the kernel exports to userspace.
Say, kern_*.

In which case the change becomes:

#define kern_aligned_u64 unsigned long long __attribute__((aligned(8)))
#define kern_aligned_be64 __be64 __attribute__((aligned(8)))
#define kern_aligned_le64 __le64 __attribute__((aligned(8)))

(exported to userspace)

and, inside __KERNEL__:

#define aligned_u64 kern_aligned_u64

etc.  And, of course, all those bit of kernel headers which are presently
using aligned_u64 in exposed-to-userspace places should be switched to
kern_aligned_u4.


What thinkest thou?

If _that_ is all sane then we should do it all in a singe header file, say
kern_types_for_userspace.h.  include/linux/types.h would then do:

#include <linux/kern_types_for_userspace.h>

#ifdef __KERNEL__
#define aligned_u64 kern_aligned_u64
etc...

(all approximate, you-get-what-I-mean)

Duno if it'd be worth the effort, but it is The Right Thing To Do.


^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH] linux/types.h: always export 64bit aligned defines
  2008-01-28  5:33 ` Andrew Morton
@ 2008-01-29 19:43   ` Jan Engelhardt
  2008-01-30  0:16     ` Mike Frysinger
  0 siblings, 1 reply; 5+ messages in thread
From: Jan Engelhardt @ 2008-01-29 19:43 UTC (permalink / raw)
  To: Andrew Morton; +Cc: Mike Frysinger, LKML, Sam Ravnborg, David Woodhouse


On Jan 27 2008 21:33, Andrew Morton wrote:
>On Sat, 26 Jan 2008 04:23:21 -0500 Mike Frysinger <vapier@gentoo.org> wrote:
>
>> Some kernel headers exported to userspace rely on these 64bit
>> aligned defines. However, they are hidden behind
>> __KERNEL_STRICT_NAMES at the moment which means most of the time,
>> they're never actually available.

Wrong way. They are inside #ifndef __KERNEL_STRICT_NAMES, so
they _are_ available to userspace.

>> These these defines dont
>> actually conflict with normal userspace / C library types, there's
>> no reason to hide them behind the __KERNEL_STRICT_NAMES define.
>
>Maybe we shouldn't be using these helper macros in
>exported-to-userspace headers.  Do you know which headers are
>affected?  Did you consider jsut expanding the macros in situ for
>thse cases?

grep aligned_u64 include/linux/netfilter{,ipv4,ipv6}/*.h

iptables uses that, but we can get rid of it if need be.
It just throws up 3 lines anyway, ...

>But I'd have thought that if we're going to do this, we should create a
>standard naming convention for types which the kernel exports to userspace.
>Say, kern_*.
>
>In which case the change becomes:
>
>#define kern_aligned_u64 unsigned long long __attribute__((aligned(8)))
>#define kern_aligned_be64 __be64 __attribute__((aligned(8)))
>#define kern_aligned_le64 __le64 __attribute__((aligned(8)))
>
>
>What thinkest thou?

... so could use __attribute__((aligned(8))) directly for exported
headers, like we currently do for pointers (since there is no
alignedptr_64 or so).

>If _that_ is all sane then we should do it all in a singe header file, say
>kern_types_for_userspace.h.  include/linux/types.h would then do:

<linux/utypes.h> maybe? (not_so_long_filenames_please.h.)

>#include <linux/kern_types_for_userspace.h>
>
>#ifdef __KERNEL__
>#define aligned_u64 kern_aligned_u64
>etc...
>
>(all approximate, you-get-what-I-mean)
>
>Duno if it'd be worth the effort, but it is The Right Thing To Do.

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH] linux/types.h: always export 64bit aligned defines
  2008-01-29 19:43   ` Jan Engelhardt
@ 2008-01-30  0:16     ` Mike Frysinger
  2008-01-30  0:37       ` Jan Engelhardt
  0 siblings, 1 reply; 5+ messages in thread
From: Mike Frysinger @ 2008-01-30  0:16 UTC (permalink / raw)
  To: Jan Engelhardt; +Cc: Andrew Morton, LKML, Sam Ravnborg, David Woodhouse

[-- Attachment #1: Type: text/plain, Size: 805 bytes --]

On Tuesday 29 January 2008, Jan Engelhardt wrote:
> On Jan 27 2008 21:33, Andrew Morton wrote:
> >On Sat, 26 Jan 2008 04:23:21 -0500 Mike Frysinger <vapier@gentoo.org> 
wrote:
> >> Some kernel headers exported to userspace rely on these 64bit
> >> aligned defines. However, they are hidden behind
> >> __KERNEL_STRICT_NAMES at the moment which means most of the time,
> >> they're never actually available.
>
> Wrong way.

i'm thinking the right way, i just may not have expressed it completely 
clearly ...

> They are inside #ifndef __KERNEL_STRICT_NAMES, so 
> they _are_ available to userspace.

for all practical purposes, they are not.  glibc will define 
__KERNEL_STRICT_NAMES because (like a sane C lib), it defines all of the 
basic types that the kernel also defines.
-mike

[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 827 bytes --]

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH] linux/types.h: always export 64bit aligned defines
  2008-01-30  0:16     ` Mike Frysinger
@ 2008-01-30  0:37       ` Jan Engelhardt
  0 siblings, 0 replies; 5+ messages in thread
From: Jan Engelhardt @ 2008-01-30  0:37 UTC (permalink / raw)
  To: Mike Frysinger; +Cc: Andrew Morton, LKML, Sam Ravnborg, David Woodhouse


On Jan 29 2008 19:16, Mike Frysinger wrote:
>> >> Some kernel headers exported to userspace rely on these 64bit
>> >> aligned defines. However, they are hidden behind
>> >> __KERNEL_STRICT_NAMES at the moment which means most of the time,
>> >> they're never actually available.
>>
>> Wrong way.
>
>i'm thinking the right way, i just may not have expressed it completely 
>clearly ...
>
>> They are inside #ifndef __KERNEL_STRICT_NAMES, so 
>> they _are_ available to userspace.
>
>for all practical purposes, they are not.  glibc will define 
>__KERNEL_STRICT_NAMES because (like a sane C lib), it defines all of the 
>basic types that the kernel also defines.

Phew - now we have two sorts of userspace? (Those with glibc and
those without, aka standalone). Right, it's messy, which is why
this thread exists and a better solution is sought :)

^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2008-01-30  0:38 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2008-01-26  9:23 [PATCH] linux/types.h: always export 64bit aligned defines Mike Frysinger
2008-01-28  5:33 ` Andrew Morton
2008-01-29 19:43   ` Jan Engelhardt
2008-01-30  0:16     ` Mike Frysinger
2008-01-30  0:37       ` Jan Engelhardt

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).