LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Jan Engelhardt <jengelh@computergmbh.de>
To: "Martin K. Petersen" <martin.petersen@oracle.com>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH] lib: Add support for DIF CRC
Date: Wed, 30 Jan 2008 15:56:56 +0100 (CET)	[thread overview]
Message-ID: <Pine.LNX.4.64.0801301555450.15249@fbirervta.pbzchgretzou.qr> (raw)
In-Reply-To: <yq14pcv94sp.fsf@sermon.lab.mkp.net>


On Jan 30 2008 02:00, Martin K. Petersen wrote:
>diff -r f5ec697e8b10 include/linux/crc-t10dif.h
>--- /dev/null	Thu Jan 01 00:00:00 1970 +0000
>+++ b/include/linux/crc-t10dif.h	Tue Jan 29 13:26:19 2008 -0500
>@@ -0,0 +1,9 @@
>+#ifndef _LINUX_CRC_T10DIF_H
>+#define _LINUX_CRC_T10DIF_H
>+
>+#include <linux/types.h>
>+
>+const __u16 t10_dif_crc_table[256];
>+__u16 crc_t10dif(unsigned char const *, size_t);
>+
>+const __u16 t10_dif_crc_table[256] = {
...
>+};
>+
>+__u16 crc_t10dif(const unsigned char *buffer, size_t len)
>+{
...
>+}
>+
>+EXPORT_SYMBOL(crc_t10dif);


One minor nitpick still: if t10_dif_crc_table is not EXPORT_SYMBOLed,
it should be static, since I do not see a reason to only make it
available to built-in code.

So either make the table static too, or EXPORT it. I am not sure if
any code needs to access the table directly, though, so I'd be going
for the static.

  reply	other threads:[~2008-01-30 14:57 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-01-30  7:00 Martin K. Petersen
2008-01-30 14:56 ` Jan Engelhardt [this message]
  -- strict thread matches above, loose matches on Subject: below --
2008-01-29 18:27 Martin K. Petersen
2008-01-29 19:21 ` Jan Engelhardt
2008-01-30  6:59   ` Martin K. Petersen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Pine.LNX.4.64.0801301555450.15249@fbirervta.pbzchgretzou.qr \
    --to=jengelh@computergmbh.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=martin.petersen@oracle.com \
    --subject='Re: [PATCH] lib: Add support for DIF CRC' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).