LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Hugh Dickins <hugh@veritas.com>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: Ingo Molnar <mingo@elte.hu>, Thomas Gleixner <tglx@linutronix.de>,
	Andi Kleen <ak@suse.de>,
	linux-kernel@vger.kernel.org
Subject: [PATCH mm] stop c_p_a corrupting the pds
Date: Tue, 5 Feb 2008 22:27:21 +0000 (GMT)	[thread overview]
Message-ID: <Pine.LNX.4.64.0802052226140.11822@blonde.site> (raw)
In-Reply-To: <Pine.LNX.4.64.0802052218190.11822@blonde.site>

When change_page_attr splits a large page on x86_32 (without PAE), it is
currently corrupting every process's page directory: fix that by removing
the thinko which passes down a physical instead of a virtual address -
this version of the patch being the hotfix for 2.6.24-mm1.

Signed-off-by: Hugh Dickins <hugh@veritas.com>

--- 2.6.24-mm1/arch/x86/mm/pageattr.c	2008-02-04 12:25:09.000000000 +0000
+++ linux/arch/x86/mm/pageattr.c	2008-02-05 20:52:43.000000000 +0000
@@ -218,8 +218,7 @@ static int split_large_page(pte_t *kpte,
 		goto out_unlock;
 	}
 
-	address = __pa(address);
-	addr = address & LARGE_PAGE_MASK;
+	addr = __pa(address) & LARGE_PAGE_MASK;
 	pbase = (pte_t *)page_address(base);
 #ifdef CONFIG_X86_32
 	paravirt_alloc_pt(&init_mm, page_to_pfn(base));

  reply	other threads:[~2008-02-05 22:28 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-02-05 22:26 [PATCH] " Hugh Dickins
2008-02-05 22:27 ` Hugh Dickins [this message]
2008-02-06  2:05   ` [PATCH mm] " Valdis.Kletnieks
2008-02-06  4:49     ` Hugh Dickins
2008-02-06  8:26 ` [PATCH] " Ingo Molnar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Pine.LNX.4.64.0802052226140.11822@blonde.site \
    --to=hugh@veritas.com \
    --cc=ak@suse.de \
    --cc=akpm@linux-foundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    --cc=tglx@linutronix.de \
    --subject='Re: [PATCH mm] stop c_p_a corrupting the pds' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).