LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
* [PATCH 3/8] drivers/net/e1000: Use FIELD_SIZEOF
@ 2008-02-10 20:11 Julia Lawall
  0 siblings, 0 replies; only message in thread
From: Julia Lawall @ 2008-02-10 20:11 UTC (permalink / raw)
  To: e1000-devel, cramerj, john.ronciak, jeffrey.t.kirsher
  Cc: linux-kernel, kernel-janitors

From: Julia Lawall <julia@diku.dk>

Robert P.J. Day proposed to use the macro FIELD_SIZEOF in replace of code
that matches its definition.

The modification was made using the following semantic patch
(http://www.emn.fr/x-info/coccinelle/)

// <smpl>
@haskernel@
@@

#include <linux/kernel.h>

@depends on haskernel@
type t;
identifier f;
@@

- (sizeof(((t*)0)->f))
+ FIELD_SIZEOF(t, f)

@depends on haskernel@
type t;
identifier f;
@@

- sizeof(((t*)0)->f)
+ FIELD_SIZEOF(t, f)
// </smpl>

Signed-off-by: Julia Lawall <julia@diku.dk>

---

diff -u -p a/drivers/net/e1000/e1000_ethtool.c b/drivers/net/e1000/e1000_ethtool.c
--- a/drivers/net/e1000/e1000_ethtool.c 2008-02-02 15:28:19.000000000 +0100
+++ b/drivers/net/e1000/e1000_ethtool.c 2008-02-10 17:58:20.000000000 +0100
@@ -50,7 +50,7 @@ struct e1000_stats {
 	int stat_offset;
 };
 
-#define E1000_STAT(m) sizeof(((struct e1000_adapter *)0)->m), \
+#define E1000_STAT(m) FIELD_SIZEOF(struct e1000_adapter, m), \
 		      offsetof(struct e1000_adapter, m)
 static const struct e1000_stats e1000_gstrings_stats[] = {
 	{ "rx_packets", E1000_STAT(stats.gprc) },

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2008-02-10 20:11 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2008-02-10 20:11 [PATCH 3/8] drivers/net/e1000: Use FIELD_SIZEOF Julia Lawall

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).