LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Jiri Kosina <jkosina@suse.cz>
To: "Adolfo R. Brandes" <arbrandes@gmail.com>
Cc: linux-kernel@vger.kernel.org
Subject: Re: USB HID: Missing keys on Gyration Media Center Universal Remote Control
Date: Mon, 11 Feb 2008 21:17:41 +0100 (CET)	[thread overview]
Message-ID: <Pine.LNX.4.64.0802112115580.7699@twin.jikos.cz> (raw)
In-Reply-To: <b4292e150801180958v43350590pc6ed4683bfc478ab@mail.gmail.com>

On Fri, 18 Jan 2008, Adolfo R. Brandes wrote:

>   I decided to ask the folks at Gyration about this before tearing my 
> (and Jiri's) hair out, and it seems that the 3 "missing keys" are 
> actually not meant to send USB signals, only IR ones.  I tested it on 
> Windows using an usb bus tracer, and as expected (duh) nothing gets 
> through for them.
>   Sorry about this, Jiri (although the "TV" and "Power" keys are still
> broken :)!

Hi Adolfo,

could you please try the testing patch below (against 2.6.24) and report 
back if it makes your "Power" and "TV" keys work? (and if it does not, 
please attach HID debugging output, as you already did before). Sorry that 
it took me too long to reply.

diff --git a/drivers/hid/hid-input.c b/drivers/hid/hid-input.c
index 0b27da7..fc6e77e 100644
--- a/drivers/hid/hid-input.c
+++ b/drivers/hid/hid-input.c
@@ -802,6 +802,7 @@ static void hidinput_configure_usage(struct hid_input *hidinput, struct hid_fiel
 		case HID_UP_LOGIVENDOR:
 			set_bit(EV_REP, input->evbit);
 			switch(usage->hid & HID_USAGE) {
+				case 0x000: map_key_clear(KEY_TV);
 				/* Reported on Logitech Ultra X Media Remote */
 				case 0x004: map_key_clear(KEY_AGAIN);		break;
 				case 0x00d: map_key_clear(KEY_HOME);		break;
@@ -1039,6 +1040,28 @@ void hidinput_hid_event(struct hid_device *hid, struct hid_field *field, struct
 		return;
 	}
 
+	/* "Sleep" key */
+	if (hid->vendor == 0x0c16 && hid->product == 0x0002 &&
+			(usage->hid & HID_USAGE_PAGE == HID_UP_GENDESK) &&
+			(usage->hid & 0xf0 == 0x80)  &&
+			(usage->hid & 0xf == 0x2)) {
+		input_event(input, usage->type, usage->code, 1);
+		input_sync(input);
+		intpu_event(input, usage->type, usage->code, 0);
+		input_sync(input);
+		return;
+	}
+	/* "TV" key */
+	if (hid->vendor == 0x0c16 && hid->product == 0x0002 &&
+			(usage->hid & HID_USAGE_PAGE == HID_UP_LOGIVENDOR) &&
+			(usage->hid & HID_USAGE == 0x0000))
+		input_event(input, usage->type, usage->code, 1);
+		input_sync(input);
+		intpu_event(input, usage->type, usage->code, 0);
+		input_sync(input);
+		return;
+	}
+
 	/* Handling MS keyboards special buttons */
 	if (IS_MS_KB(hid) && usage->hid == (HID_UP_MSVENDOR | 0xff05)) {
 		int key = 0;

  reply	other threads:[~2008-02-11 20:18 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-12-28 16:48 Adolfo R. Brandes
2008-01-09 14:12 ` Jiri Kosina
2008-01-09 17:53   ` Adolfo R. Brandes
2008-01-17 13:26 ` Jiri Kosina
2008-01-18 17:01   ` Adolfo R. Brandes
2008-01-18 17:58     ` Adolfo R. Brandes
2008-02-11 20:17       ` Jiri Kosina [this message]
2008-02-12 13:23         ` Adolfo R. Brandes
2008-02-12 15:09           ` Adolfo R. Brandes
2008-02-19 12:43             ` Jiri Kosina
2008-02-19 13:04               ` Jiri Kosina
2008-06-16 23:31 Philippe Troin
2008-06-17 14:00 ` Jiri Kosina
2008-06-17 16:34   ` Philippe Troin
2008-06-18  9:40 ` Jiri Kosina
2008-06-19 20:48   ` Philippe Troin
2008-08-01  0:28     ` Philippe Troin
2008-08-01  9:29       ` Jiri Kosina

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Pine.LNX.4.64.0802112115580.7699@twin.jikos.cz \
    --to=jkosina@suse.cz \
    --cc=arbrandes@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --subject='Re: USB HID: Missing keys on Gyration Media Center Universal Remote Control' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).