LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Jiri Kosina <jikos@jikos.cz>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: Jonathan Corbet <corbet@lwn.net>,
	linux-kernel@vger.kernel.org, torvalds@linux-foundation.org
Subject: Re: [PATCH] Avoid buffer overflows in get_user_pages()
Date: Tue, 12 Feb 2008 11:35:02 +0100 (CET)	[thread overview]
Message-ID: <Pine.LNX.4.64.0802121133090.7699@twin.jikos.cz> (raw)
In-Reply-To: <20080211234628.b5533b87.akpm@linux-foundation.org>

On Mon, 11 Feb 2008, Andrew Morton wrote:

> > +	if (len <= 0)
> > +		return 0;
> >  	/* 
> >  	 * Require read or write permissions.
> >  	 * If 'force' is set, we only require the "MAY" flags.
> Can we just convert
> 	do {
> 		...
> 	} while (len);
> into
> 	while (len) {
> 		...
> 	}

How would that help?

Rather

	while (len > 0) {
		...
	}

would do the trick.

-- 
Jiri Kosina

  reply	other threads:[~2008-02-12 10:36 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-02-11 23:17 Jonathan Corbet
2008-02-11 23:45 ` Nick Piggin
2008-02-12  7:46 ` Andrew Morton
2008-02-12 10:35   ` Jiri Kosina [this message]
2008-02-14 16:45 ` Oliver Pinter
2008-02-14 21:09   ` Jonathan Corbet
     [not found] <fa.5jOFf0zR7ZoK3hLDItf3Omow4lE@ifi.uio.no>
     [not found] ` <fa.NNs+hqAlLlf93+yNZ/YJzSyGQbs@ifi.uio.no>
2008-02-12  3:16   ` Robert Hancock
2008-02-12  5:56     ` Nick Piggin
     [not found] <9VQ6w-5Xn-7@gated-at.bofh.it>
     [not found] ` <9VY4a-1tI-21@gated-at.bofh.it>
2008-02-12  8:34   ` Bodo Eggert

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Pine.LNX.4.64.0802121133090.7699@twin.jikos.cz \
    --to=jikos@jikos.cz \
    --cc=akpm@linux-foundation.org \
    --cc=corbet@lwn.net \
    --cc=linux-kernel@vger.kernel.org \
    --cc=torvalds@linux-foundation.org \
    --subject='Re: [PATCH] Avoid buffer overflows in get_user_pages()' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).