LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Jan Engelhardt <jengelh@computergmbh.de>
To: Andy Whitcroft <apw@shadowen.org>
Cc: Marcin Slusarz <marcin.slusarz@gmail.com>,
	LKML <linux-kernel@vger.kernel.org>
Subject: Re: bug in checkpatch (on pointers to typedefs?)
Date: Thu, 14 Feb 2008 19:29:16 +0100 (CET)	[thread overview]
Message-ID: <Pine.LNX.4.64.0802141928130.694@fbirervta.pbzchgretzou.qr> (raw)
In-Reply-To: <20080214100617.GB10713@shadowen.org>


On Feb 14 2008 10:06, Andy Whitcroft wrote:
>On Wed, Feb 13, 2008 at 08:43:58PM +0100, Jan Engelhardt wrote:
>> 
>> On Feb 10 2008 15:33, Marcin Slusarz wrote:
>> >Checkpatch in current mainline outputs following errors:
>> >
>> >$ ./scripts/checkpatch.pl -q --file ./fs/udf/misc.c
>> >ERROR: need consistent spacing around '*' (ctx:WxV)
>> >#205: FILE: fs/udf/misc.c:205:
>> >+       tag *tag_p;
>> >            ^
>> 
>> I'd say "don't add any new typedefs" (and perhaps get rid of old ones).
>
>It should be doing that at the site of the new typedef :)
>
Additionally, yes.
Given:

typedef struct {
	...
} tag_t;
void foo(void)
{
	tag_t name;
}

A user adding

+	tag_t newthing;

could at the same time give the struct a name if it already does not
have one and instead use

+	struct tag newthing;

then.

      reply	other threads:[~2008-02-14 18:29 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-02-10 14:33 Marcin Slusarz
2008-02-11 10:23 ` Andy Whitcroft
2008-02-11 16:05   ` Benny Halevy
2008-02-11 16:40     ` Andy Whitcroft
2008-02-11 16:58       ` Benny Halevy
2008-02-11 18:42         ` Andy Whitcroft
2008-02-12  8:21           ` Benny Halevy
2008-02-11 18:09   ` Marcin Slusarz
2008-02-13 19:43 ` Jan Engelhardt
2008-02-14 10:06   ` Andy Whitcroft
2008-02-14 18:29     ` Jan Engelhardt [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Pine.LNX.4.64.0802141928130.694@fbirervta.pbzchgretzou.qr \
    --to=jengelh@computergmbh.de \
    --cc=apw@shadowen.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=marcin.slusarz@gmail.com \
    --subject='Re: bug in checkpatch (on pointers to typedefs?)' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).