LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Christoph Lameter <clameter@sgi.com>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: dada1@cosmosbay.com, davem@davemloft.net,
linux-kernel@vger.kernel.org, netdev@vger.kernel.org,
yanmin_zhang@linux.intel.com, travis@sgi.com
Subject: Re: [PATCH] alloc_percpu() fails to allocate percpu data
Date: Wed, 27 Feb 2008 13:56:55 -0800 (PST) [thread overview]
Message-ID: <Pine.LNX.4.64.0802271353520.12963@schroedinger.engr.sgi.com> (raw)
In-Reply-To: <20080227122451.6a3b5565.akpm@linux-foundation.org>
On Wed, 27 Feb 2008, Andrew Morton wrote:
> On Wed, 27 Feb 2008 11:59:32 -0800 (PST)
> Christoph Lameter <clameter@sgi.com> wrote:
>
> > Any decision made on what to do about this one? Mike or I can
> > repost the per cpu allocator against mm? The fix by Eric could be used
> > in the interim for 2.6.24?
> >
>
> I suppose I'll merge Eric's patch when I've tested it fully (well, as fully
> as I test stuff).
Urgh. You too?
> It'd be nice to get that cache_line_size()/L1_CACHE_BYTES/L1_CACHE_ALIGN()
> mess sorted out. If it's a mess - I _think_ it is?
Well I tried it when slub went first in and it did not go well. The issue
is that x86 detects the cache line size on bootup. Thus cache_line_size().
Most of the other arch have compile time cache line sizes. Thus
L1_CACHE_BYTES. So L1_CACHE_BYTES is the maximum value that
cache_line_size() can take.
What I was attempting to do is to make x86 have one compile time cache
line size L1_CACHE_BYTES. That raised objections because space was wasted.
next prev parent reply other threads:[~2008-02-27 21:57 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-02-21 18:00 Eric Dumazet
2008-02-21 22:26 ` Peter Zijlstra
2008-02-23 9:23 ` Nick Piggin
2008-02-27 19:44 ` Christoph Lameter
2008-03-03 3:14 ` Nick Piggin
2008-03-03 7:48 ` Eric Dumazet
2008-03-03 9:41 ` Nick Piggin
2008-03-03 19:30 ` Christoph Lameter
2008-02-23 8:04 ` Andrew Morton
2008-02-27 19:59 ` Christoph Lameter
2008-02-27 20:24 ` Andrew Morton
2008-02-27 21:56 ` Christoph Lameter [this message]
2008-03-01 13:53 ` Eric Dumazet
2008-03-11 18:15 ` Mike Snitzer
2008-03-11 18:41 ` Eric Dumazet
2008-03-11 19:39 ` Mike Snitzer
2008-03-12 0:18 ` [stable] " Chris Wright
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Pine.LNX.4.64.0802271353520.12963@schroedinger.engr.sgi.com \
--to=clameter@sgi.com \
--cc=akpm@linux-foundation.org \
--cc=dada1@cosmosbay.com \
--cc=davem@davemloft.net \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=travis@sgi.com \
--cc=yanmin_zhang@linux.intel.com \
--subject='Re: [PATCH] alloc_percpu() fails to allocate percpu data' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).