LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
* [PATCH] MM: Fix macro argument substitution in PageHead() and PageTail()
@ 2008-02-21 16:12 David Howells
  2008-02-27 23:10 ` Christoph Lameter
  0 siblings, 1 reply; 2+ messages in thread
From: David Howells @ 2008-02-21 16:12 UTC (permalink / raw)
  To: torvalds, akpm, clameter; +Cc: linux-kernel, dhowells

From: David Howells <dhowells@redhat.com>

Fix macro argument substitution in PageHead() and PageTail() - 'page' should
have brackets surrounding it (commit 6d7779538f765963ced45a3fa4bed7ba8d2c277d).

Signed-off-by: David Howells <dhowells@redhat.com>
---

 include/linux/page-flags.h |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)


diff --git a/include/linux/page-flags.h b/include/linux/page-flags.h
index bbad43f..b5b30f1 100644
--- a/include/linux/page-flags.h
+++ b/include/linux/page-flags.h
@@ -266,7 +266,7 @@ static inline void SetPageUptodate(struct page *page)
 
 #define PG_head_tail_mask ((1L << PG_compound) | (1L << PG_reclaim))
 
-#define PageTail(page)	((page->flags & PG_head_tail_mask) \
+#define PageTail(page)	(((page)->flags & PG_head_tail_mask)	\
 				== PG_head_tail_mask)
 
 static inline void __SetPageTail(struct page *page)
@@ -279,7 +279,7 @@ static inline void __ClearPageTail(struct page *page)
 	page->flags &= ~PG_head_tail_mask;
 }
 
-#define PageHead(page)	((page->flags & PG_head_tail_mask) \
+#define PageHead(page)	(((page)->flags & PG_head_tail_mask)	\
 				== (1L << PG_compound))
 #define __SetPageHead(page)	__SetPageCompound(page)
 #define __ClearPageHead(page)	__ClearPageCompound(page)


^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH] MM: Fix macro argument substitution in PageHead() and PageTail()
  2008-02-21 16:12 [PATCH] MM: Fix macro argument substitution in PageHead() and PageTail() David Howells
@ 2008-02-27 23:10 ` Christoph Lameter
  0 siblings, 0 replies; 2+ messages in thread
From: Christoph Lameter @ 2008-02-27 23:10 UTC (permalink / raw)
  To: David Howells; +Cc: torvalds, akpm, linux-kernel

On Thu, 21 Feb 2008, David Howells wrote:

> Fix macro argument substitution in PageHead() and PageTail() - 'page' should
> have brackets surrounding it (commit 6d7779538f765963ced45a3fa4bed7ba8d2c277d).

Acked-by: Christoph Lameter <clameter@sgi.com>


^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2008-02-27 23:13 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2008-02-21 16:12 [PATCH] MM: Fix macro argument substitution in PageHead() and PageTail() David Howells
2008-02-27 23:10 ` Christoph Lameter

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).