LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
* permissions on /proc/tty/driver/
@ 2008-02-29 18:16 Thomas Voegtle
  2008-03-03 16:42 ` Thomas Voegtle
  0 siblings, 1 reply; 2+ messages in thread
From: Thomas Voegtle @ 2008-02-29 18:16 UTC (permalink / raw)
  To: linux-kernel; +Cc: tilman.baumann, Andreas Hofmeister

[-- Attachment #1: Type: TEXT/PLAIN, Size: 1054 bytes --]


Hi,

we noticed that only root can enter /proc/tty/driver/, which appears to be 
wrong, because the files therein are actually world readable...



Signed-off-by: Tilman Baumann <tilman.baumann@collax.comy>
Signed-off-by: Thomas Voegtle <tv@lio96.de>
---
 fs/proc/proc_tty.c |    4 +++-
 1 files changed, 3 insertions(+), 1 deletions(-)

diff --git a/fs/proc/proc_tty.c b/fs/proc/proc_tty.c
index 49816e0..eb73d96 100644
--- a/fs/proc/proc_tty.c
+++ b/fs/proc/proc_tty.c
@@ -224,7 +224,9 @@ void __init proc_tty_init(void)
 	 * password lengths and inter-keystroke timings during password
 	 * entry.
 	 */
-	proc_tty_driver = proc_mkdir_mode("tty/driver", S_IRUSR | S_IXUSR, NULL);
+	proc_tty_driver = proc_mkdir_mode("tty/driver",
+			S_IRUSR|S_IXUSR|S_IRGRP|S_IXGRP|S_IROTH|S_IXOTH,
+			NULL);
 
 	create_proc_read_entry("tty/ldiscs", 0, NULL, tty_ldiscs_read_proc, NULL);
 	entry = create_proc_entry("tty/drivers", 0, NULL);
-- 
1.5.3

      Thomas

-- 
 Thomas Vögtle    email: thomas@voegtle-clan.de
 ----- http://www.voegtle-clan.de/thomas ------

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: permissions on /proc/tty/driver/
  2008-02-29 18:16 permissions on /proc/tty/driver/ Thomas Voegtle
@ 2008-03-03 16:42 ` Thomas Voegtle
  0 siblings, 0 replies; 2+ messages in thread
From: Thomas Voegtle @ 2008-03-03 16:42 UTC (permalink / raw)
  To: linux-kernel; +Cc: tilman.baumann, Andreas Hofmeister

[-- Attachment #1: Type: TEXT/PLAIN, Size: 554 bytes --]

On Fri, 29 Feb 2008, Thomas Voegtle wrote:

> we noticed that only root can enter /proc/tty/driver/, which appears to be 
> wrong, because the files therein are actually world readable...

I found out why this was done:

http://www.kernel.org/pub/linux/kernel/v2.4/ChangeLog-2.4.29

Chris Wright:
  o /proc/tty/driver/serial reveals the exact number of characters used
in serial links (CAN-2003-0461)


So, please ignore this patch I sent.

      Thomas

-- 
 Thomas Vögtle    email: thomas@voegtle-clan.de
 ----- http://www.voegtle-clan.de/thomas ------

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2008-03-03 16:42 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2008-02-29 18:16 permissions on /proc/tty/driver/ Thomas Voegtle
2008-03-03 16:42 ` Thomas Voegtle

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).