LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Jiri Kosina <jkosina@suse.cz>
To: Pekka Sarnila <sarnila@adit.fi>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [patch] hid: quirk to fixup fullspeed interval on highspeed devices
Date: Mon, 3 Mar 2008 13:50:14 +0100 (CET)	[thread overview]
Message-ID: <Pine.LNX.4.64.0803031333080.15209@jikos.suse.cz> (raw)
In-Reply-To: <47C96DEB.5070304@adit.fi>

On Sat, 1 Mar 2008, Pekka Sarnila wrote:

> Many vendors highspeed devices give erroneously fullspeed interval value 
> in endpoint descriptor for interrupt endpoints. This quirk fixes up that 
> by recalculating the right value for highspeed device.

Hi Pekka,

thanks for the patch. I however think that HID code is really a wrong 
place to to this, we really want to do this in USB core instead, as that 
it where it belongs.

Why do you think that adding a new quirk for this device to 
usb/core/quirks.c and then checking for it in usb_parse_endpoint() is not 
feasible?

Thanks,

-- 
Jiri Kosina
SUSE Labs

  reply	other threads:[~2008-03-03 12:50 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-03-01 14:53 Pekka Sarnila
2008-03-03 12:50 ` Jiri Kosina [this message]
2008-03-03 14:38   ` Pekka Sarnila
2008-03-06 12:08     ` Jiri Kosina

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Pine.LNX.4.64.0803031333080.15209@jikos.suse.cz \
    --to=jkosina@suse.cz \
    --cc=linux-kernel@vger.kernel.org \
    --cc=sarnila@adit.fi \
    --subject='Re: [patch] hid: quirk to fixup fullspeed interval on highspeed devices' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).